Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932521AbWHCOdT (ORCPT ); Thu, 3 Aug 2006 10:33:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932526AbWHCOdT (ORCPT ); Thu, 3 Aug 2006 10:33:19 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:52890 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932521AbWHCOdS (ORCPT ); Thu, 3 Aug 2006 10:33:18 -0400 Date: Thu, 3 Aug 2006 15:33:17 +0100 From: Christoph Hellwig To: Dave Hansen Cc: linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk, herbert@13thfloor.at, hch@infradead.org Subject: Re: [PATCH 02/28] r/o bind mount prepwork: move open_namei()'s vfs_create() Message-ID: <20060803143317.GB920@infradead.org> Mail-Followup-To: Christoph Hellwig , Dave Hansen , linux-kernel@vger.kernel.org, viro@ftp.linux.org.uk, herbert@13thfloor.at References: <20060801235240.82ADCA42@localhost.localdomain> <20060801235241.D7516044@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060801235241.D7516044@localhost.localdomain> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 24 On Tue, Aug 01, 2006 at 04:52:41PM -0700, Dave Hansen wrote: > > The code around vfs_create() in open_namei() is getting a > bit too complex. Right now, there is at least the reference > count on the dentry, and the i_mutex to worry about. Soon, > we'll also have mnt_writecount. > > So, break the vfs_create() call out of open_namei(), and > into a helper function. This duplicates the call to > may_open(), but that isn't such a bad thing since the > arguments (acc_mode and flag) were being heavily massaged > anyway. > > Later in the series, we'll add the mnt_writecount handling > around this new function call. > Ok. Again please send to Andrew ASAP. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/