Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3850626pxk; Tue, 22 Sep 2020 04:26:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzARFYaNFu+wHc6T9fyRsVFm8MRz0cnR7a3izggtXmsZRrXb3gZ3cgveQIWNW+7onc4AGt2 X-Received: by 2002:aa7:da0f:: with SMTP id r15mr3271929eds.321.1600774019589; Tue, 22 Sep 2020 04:26:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600774019; cv=none; d=google.com; s=arc-20160816; b=jKm/kYpLKw3guJ+66YV49ILuIF7o6wievnfbl8fx65JUji9vXGcyBE2lk9+KQJ2DeH 254Lp3S1LbEVa2fZBZKcMLMs67lkYQLIWwBjr7/f0a575cznIeFPQrnKucoLqDkFvhId HqpbpWsQPRnGQ4Ci56K5nMcLBFCHtH48sVjIQU6+KVhFf9fZN7CVRUBKzSvqs9On+qsk UY6kWLjfnjSTH5XZIGZ2jd3aLs/fA3nvAmS/uRKW11VOCjOxUd5z1F5WDZ/6b5qe9/IF BRReuTJDGF8z/hmhgrjT+iZXE+b8zTA//SKsmUVmGZIC4XcZoeWeS1Vz7Rt3Y2mtdunC /31g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/l/1boT6rYXVxRbbfPm5cPvojJRCyVemUpkPuFN8Gfc=; b=RxO+0Dw5/EPF75GKT27dR+L9J6wJQxjMqJyDwao0ioTY+eheA7ks+CIDG39t4z2XWf VbrbM44nuoqcxF4U8aFA051+1QjgCbU9s69QIcniiPsepUI+WYZBJDqLxmG0sIcYvIvl BSszMuWecX2MrUfz2rrtfKwXSN5sxEOihrha0cZZl9ikg9EAYN9TARls3El128hQjq09 BR+YEMwVqfpoogiIiO54TztyrqpIQqMFWCBEXQMbCGMbr4oMN51kBs5YSiRKxC5zOAE7 aHfpiG+wUd0QRo4yINqW4aVvfMm+qZkHfvnXNzd0ZGyFeUBsqMKEzSdS59Jv6XMnX66o lmVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qFAC4RZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f6si10383946edj.365.2020.09.22.04.26.36; Tue, 22 Sep 2020 04:26:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qFAC4RZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbgIVLXF (ORCPT + 99 others); Tue, 22 Sep 2020 07:23:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:42108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbgIVLW7 (ORCPT ); Tue, 22 Sep 2020 07:22:59 -0400 Received: from mail.kernel.org (ip5f5ad5bc.dynamic.kabel-deutschland.de [95.90.213.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4504A238A1; Tue, 22 Sep 2020 11:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600773778; bh=g4d13BGuduKPDFBeIc0TlyYXYMgjU5xW76V6a9jLQR8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qFAC4RZfT24s/PKljc7ePg9CEg6N48QFIfbVuvW7LSEciDZtp1roeIHpygS8F0xlk 0ACjF6eT9NgVwfNvgrOQdqYrAFMeCbUbnUHQViLke/7l05Cu+6EkKpgVTGyA/srih5 QPlW0Dyz0vLtinRbxAxNYsUbY9iAQiSCje7BZi+8= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1kKgNr-0010Kg-Lx; Tue, 22 Sep 2020 13:22:55 +0200 From: Mauro Carvalho Chehab To: Linux Doc Mailing List Cc: Mauro Carvalho Chehab , "David S. Miller" , "Jonathan Corbet" , Alexei Starovoitov , Andrii Nakryiko , Cong Wang , Eric Dumazet , Francesco Ruggeri , Jakub Kicinski , Jiri Pirko , Taehee Yoo , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 1/3] net: fix a new kernel-doc warning at dev.c Date: Tue, 22 Sep 2020 13:22:52 +0200 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernel-doc expects the function prototype to be just after the kernel-doc markup, as otherwise it will get it all wrong: ./net/core/dev.c:10036: warning: Excess function parameter 'dev' description in 'WAIT_REFS_MIN_MSECS' Fixes: 0e4be9e57e8c ("net: use exponential backoff in netdev_wait_allrefs") Signed-off-by: Mauro Carvalho Chehab --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index a268ff35ad38..873b50ac9668 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -10021,6 +10021,8 @@ int netdev_refcnt_read(const struct net_device *dev) } EXPORT_SYMBOL(netdev_refcnt_read); +#define WAIT_REFS_MIN_MSECS 1 +#define WAIT_REFS_MAX_MSECS 250 /** * netdev_wait_allrefs - wait until all references are gone. * @dev: target net_device @@ -10033,8 +10035,6 @@ EXPORT_SYMBOL(netdev_refcnt_read); * We can get stuck here if buggy protocols don't correctly * call dev_put. */ -#define WAIT_REFS_MIN_MSECS 1 -#define WAIT_REFS_MAX_MSECS 250 static void netdev_wait_allrefs(struct net_device *dev) { unsigned long rebroadcast_time, warning_time; -- 2.26.2