Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Po Liu <po.liu@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: Re: [net-next] net: dsa: felix: convert TAS link speed based on
 phylink speed
Thread-Topic: [net-next] net: dsa: felix: convert TAS link speed based on
 phylink speed
Thread-Index: AQHWkM5TxPSfPwtzN0aAaqrvypiio6l0h64A
Date:   Tue, 22 Sep 2020 11:36:45 +0000
Message-ID: <20200922113644.h5vyxmdtg2dickpg@skbuf>
References: <20200922104302.17662-1-xiaoliang.yang_1@nxp.com>
In-Reply-To: <20200922104302.17662-1-xiaoliang.yang_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B85369DC1D064847A1B9792A27CCB895@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e74f436-ec8b-4c93-6a3b-08d85eebc935
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2020 11:36:45.7592
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c6/2JXJgJEuylbB+R4gfd/HQw4aLnQVcjiNX5/7c0mvtf65WCAiOqjYEG44ASxqO7GiUCwmUUhnDmW0l+2oUdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7374
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Xiaoliang,

On Tue, Sep 22, 2020 at 06:43:02PM +0800, Xiaoliang Yang wrote:
> state->speed holds a value of 10, 100, 1000 or 2500, but
> QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the
> speed to a proper value.
>=20
> Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler via
> taprio offload")
>=20
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

But next time keep in mind the following:

- The Fixes: tag should never wrap on multiple lines, even if it exceeds
  80 characters.
- Patches that fix a problem in net-next only should go to David's
  net-next tree. Patches that fix a problem on Linus Torvalds' tree
  should go to David's "net" tree. This one should go to "net", not to
  "net-next".
- All tags (Fixes, Signed-off-by, etc) should be grouped together with
  no empty lines between them.

Actually due to the first issue I mentioned, could you please resend
this?

Thanks,
-Vladimir=