Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3866331pxk; Tue, 22 Sep 2020 04:53:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQlEidZneKwS0drQz98stTPiG1VXFHGh838kQwUyGukggbeONNc+Fz4TwNHuvocZbE9Am8 X-Received: by 2002:a50:f687:: with SMTP id d7mr3617555edn.353.1600775595015; Tue, 22 Sep 2020 04:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600775595; cv=none; d=google.com; s=arc-20160816; b=DxrDxN50FAgLi7isSoZszoyYk3+9yHWdHoxT3oGUqZR+N9TppV0AoT72iJfF0cM+77 6LkZf8+ttHrdTXYdTz9WrtYiaQ3rin2+E3jG9hoL4SBhXlVeWbwy7EUOhuA7Ifil/DBY cSkgC2iy/pRH41Ihxkz0pBSUEzC3mjhK2VWIurD4dJr7m01Z5vDPId3FuF9pBnnv7WqN sEFiWWhhSsEd32rTqZSAEUSDVmEBeFyeQM9N+FqQd/g3GDsea0X0OnPYBTEotGYhr87X ec/Ei5wbRsVJQ5Fdzo+FWX2H9AE7+TMd+SOYxMBYwnJEqwrq9N9MOWTw0NH1ViAyhnJj RHOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=y3qi2yrzMF5T5BtTD5/xjgExOwRqo/2TaiicBJW8AyU=; b=hK73E9W+C6XUziV1GfwkcssbMv732Whb6kPIN4BwJ+2f04ILFMl9XkW0iZhLNkZ//0 5aRA4SFxo889qiLZZqJHxzP9nQx2wpjhhxhmpu1bJJ7WIyNx/lRMcwkCUSTNmU6d8/0t g1H/sYxZOtjiPkITrjt4Kl1rB3RDFx7wO/dTdF4Am6qO4kMw/1P6gUYsADW9IVLsvTpB E5WmBoQ8yjgewdgk4/E5Gx2iwyjjNZIKn8O4Y5s1wI9F+ZpbA0sO9wZMeWiJPOLHOggO 0E0BSVn0QjcT4xlSLnmabY1gpPtIQTkYYLjoGIqvUUQ8LIhE1eV4oWXZSfKqNF0+LAVL FWoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y2si10176896ejc.669.2020.09.22.04.52.52; Tue, 22 Sep 2020 04:53:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbgIVLv5 (ORCPT + 99 others); Tue, 22 Sep 2020 07:51:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726533AbgIVLv4 (ORCPT ); Tue, 22 Sep 2020 07:51:56 -0400 Received: from smtp1.goneo.de (smtp1.goneo.de [IPv6:2001:1640:5::8:30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0471C061755 for ; Tue, 22 Sep 2020 04:51:56 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.goneo.de (Postfix) with ESMTP id 655CC23EE82; Tue, 22 Sep 2020 13:51:55 +0200 (CEST) X-Virus-Scanned: by goneo X-Spam-Flag: NO X-Spam-Score: -2.992 X-Spam-Level: X-Spam-Status: No, score=-2.992 tagged_above=-999 tests=[ALL_TRUSTED=-1, AWL=-0.092, BAYES_00=-1.9] autolearn=ham Received: from smtp1.goneo.de ([127.0.0.1]) by localhost (smtp1.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id niXY_X-4a3T9; Tue, 22 Sep 2020 13:51:54 +0200 (CEST) Received: from lem-wkst-02.lemonage (hq.lemonage.de [87.138.178.34]) by smtp1.goneo.de (Postfix) with ESMTPSA id 5FAFA23F158; Tue, 22 Sep 2020 13:51:54 +0200 (CEST) Date: Tue, 22 Sep 2020 13:51:50 +0200 From: Lars Poeschel To: Miguel Ojeda Cc: Willy Tarreau , open list Subject: Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line Message-ID: <20200922115150.w6np52gwegloei6b@lem-wkst-02.lemonage> References: <20191016082430.5955-1-poeschel@lemonage.de> <20200921144645.2061313-1-poeschel@lemonage.de> <20200921144645.2061313-32-poeschel@lemonage.de> <20200922052701.GB16386@1wt.eu> <20200922094422.ucj24ohtervhcetv@lem-wkst-02.lemonage> <20200922100400.GH16421@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2020 at 12:20:36PM +0200, Miguel Ojeda wrote: > Hi Lars, Willy, > > On Tue, Sep 22, 2020 at 12:04 PM Willy Tarreau wrote: > > > > The points you mention are good enough indicators that it's extremely > > unlikely anyone has ever used that feature with these drivers. So I > > think it's best to keep your changes and wait to see if anyone pops > > up with an obscure use case, in which case their explanation might > > help figure another approach. > > Agreed -- Lars, please add an explanation for the removed feature in > the appropriate commit message and also mention it in the cover letter > so that such user-facing change (and any other) is documented. Ok, I will do this. Regards, Lars