Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3889755pxk; Tue, 22 Sep 2020 05:29:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQf8Ch+fzcgcBt1DykfnqqoQMlQokpELQZeBgZF6Ym9/asfivjGrfVysZ/qlXQTZIB/Deq X-Received: by 2002:a17:906:819:: with SMTP id e25mr4782909ejd.211.1600777794592; Tue, 22 Sep 2020 05:29:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600777794; cv=none; d=google.com; s=arc-20160816; b=0uHK5IAOnRUebU8K23coCrY/voSSQLajofET6dt5xflH8DSNdN5uoekTrgdz5G1E8H IfoQtqjQueXxu/RCmwENOjfu/rurtwv3aqvX8fT9a8917zm7PPTJDxqQZQSlNspGZbUi OcX9nZzuayt4H4LPznIFSTP1wBu+gX0XnR6FJQcVSW2dkU8zqnE//AKSCuAYt5BoBJbP 6GTdrMqRAM37uv9EgeHf++90A9kMac/F7dRjpEF3M5WYGZJqEkP4AHupuAAqdygq+D+R Gu7o4RaJ8EhV4ytgHqNy1ZqFpX56RhAhmBCCgtFoGmJ5CwAcbZPTqrMm39f9/HcJDL8h th3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QOf2JTCyG7BLU81U37VjbgSKPGgWOzBrM3G1telCsN0=; b=QLVYVLMwFtu8Dj2qJ0gg0YZ8IbYyVEtkx1HLHmwQhiArD24SQwx942jKNkKIkdUuKu ePAgE1XSi6faQTCJSyeT8UAO2enY23zSW8KcH9tmKChRDjhLDYymKCdhW2qcfQcy6Z8G XCg3B3F3A+E6TZOOE8A2fW0AzBmWQQIbvB8swVJfNhagQomKpdZRTTP3VDgWJguj/GxY 6+0CgHGx30hH/lzyuBBKARUYPxvWgf5Ohdr8iTC6SAo9mbvOxYG+CnDQp//pH9tQRITh m/VJvFqqrqKU5rNpe8jYYGI7doY6T8g86oqshHyqQ033ZbDSbV7tmnj9Cm19FiXcPLHZ aSEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=J8vJB8PG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s3si10236872edq.248.2020.09.22.05.29.30; Tue, 22 Sep 2020 05:29:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=J8vJB8PG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726573AbgIVM2g (ORCPT + 99 others); Tue, 22 Sep 2020 08:28:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbgIVM2g (ORCPT ); Tue, 22 Sep 2020 08:28:36 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B479C061755; Tue, 22 Sep 2020 05:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QOf2JTCyG7BLU81U37VjbgSKPGgWOzBrM3G1telCsN0=; b=J8vJB8PGDvNZr3pL6E5VUXs5mh 7fhLdUsaxmKF5Q9VJEZoijpH3ddlo7CWLkRQyXc1cLv2C71vR5gsRKL2y+6Iil1ZlrXoZtpcokWZV /sViwtrr/gn3EPRdVP6nrwsLDb4Tc3+Bw1MbQjXodXO2uI6uCmMvGItmnJ1PMckk2naxTYXBelE9m BMheLjIYQiDNYHDQXPLDCJjsG/BRqimL/XtZph1DC1ZOKp9PoNiWLuWglCamn3s2nsUiTjnkFP6HE ijBWNZGs3y0YPF32Hf/NaucqXzpCPa+DAMfw8XmcB+1xqcHmO5oxGSNupyWkbzyg4ooEVZnbICIsw SUOOZ2rg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKhP9-0000rB-4w; Tue, 22 Sep 2020 12:28:19 +0000 Date: Tue, 22 Sep 2020 13:28:19 +0100 From: Matthew Wilcox To: Mikulas Patocka Cc: Dan Williams , Linus Torvalds , Alexander Viro , Andrew Morton , Vishal Verma , Dave Jiang , Ira Weiny , Jan Kara , Eric Sandeen , Dave Chinner , "Kani, Toshi" , "Norton, Scott J" , "Tadakamadla, Rajesh (DCIG/CDI/HPS Perf)" , Linux Kernel Mailing List , linux-fsdevel , linux-nvdimm Subject: Re: NVFS XFS metadata (was: [PATCH] pmem: export the symbols __copy_user_flushcache and __copy_from_user_flushcache) Message-ID: <20200922122819.GD32101@casper.infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 12:20:42PM -0400, Mikulas Patocka wrote: > The same for directories - NVFS hashes the file name and uses radix-tree > to locate a directory page where the directory entry is located. XFS > b+trees would result in much more accesses than the radix-tree. What? Radix trees behave _horribly_ badly when indexed by a hash. If you have a 64-bit hash and use 8 bits per level of the tree, you have to traverse 8 pointers to get to your destination. You might as well use a linked list!