Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3894959pxk; Tue, 22 Sep 2020 05:38:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmO2EqJ0zmcT2XPR68Yh9WMexZHChh8rf7De/jz2E2HfwosJkh9ANKzUfDGxlEn1Q8fm3q X-Received: by 2002:a05:6402:b9a:: with SMTP id cf26mr3519436edb.375.1600778281744; Tue, 22 Sep 2020 05:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600778281; cv=none; d=google.com; s=arc-20160816; b=Gy+7KW4X+sCRAKhpynz6wzHKeI1xiJBV+a25UhgqIqEf2e5Ot6BNPI9TNscjL5oKFJ v0sYzsrpmAteUxHIzobenS+8vjtaGdWgcSYSA25el0zJQ6pDNd1O1rybhuhlEOXr2IVA 2UI+SGeccKrnGK1ZZYhyDpYiPZnJJFPsmFLGTMuL2mpFwn8kHSzv8jykNnBy+E3tMW28 342defaLyAA5XXaZ62mNUyMU+KPGYsDIQ4taKDym6dOUEYlywCJ0cuiTXwK38Ah/T8SW wzvRPoXZHXCEe25mMS/4NNZS2twj2/tntF0HATV/y7NuV7G34i7X4yjQbFAICKkU8yZP Qz1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:cc:to :references:subject:dkim-signature; bh=37wPUZzrX/ueT6NMg9kdHB6XHwPYogZuEw4uPuTq8sE=; b=P85P/chJ9yHRAjBoFw8oE3QBWEH40cbfdcztIb9Q8M9bZ+mtofNwDqGa1CR8d7xVm9 6TBrUX3AGU/7qBuwn64Gw0YZ9fKCJPEOJwkRYQcR5rKcAAyX+oeOpcooMMes5VVRD8sx eOi5WfsHBX4J6BBtgzAFHDP/Xml+HqP8ALABtMbQvuqgl2BpDzOikmjgxsxmcFO8953n hQvEWe0cAcEKyxih+R0Tbzn7Qjz2f4Pk4IwendId3o+r5F+j+tMvwF9Mz4yLC5q2T0Mq jFJqwdOHvIgxys7ZM8mnR5MHqKWBR914XDefUUK7zXhNUAwatj4UaKQ0qvKBPXRPGhJs kUAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UVdqrcAo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si12090161ejb.204.2020.09.22.05.37.37; Tue, 22 Sep 2020 05:38:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UVdqrcAo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726583AbgIVMgm (ORCPT + 99 others); Tue, 22 Sep 2020 08:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbgIVMgm (ORCPT ); Tue, 22 Sep 2020 08:36:42 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9200C061755; Tue, 22 Sep 2020 05:36:41 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id gx22so13565216ejb.5; Tue, 22 Sep 2020 05:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:references:to:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=37wPUZzrX/ueT6NMg9kdHB6XHwPYogZuEw4uPuTq8sE=; b=UVdqrcAopld6iqwnmFYqqatYlAwVgvPY4GOZkUByWKVEaTSj8gDTHr6fJqu+sSvgUl P78O7cfKnKGWzh/Vlu7Dn+tRNVC/SUtIyOCCzM5yngQ4sdb2KebddqhInOnrqYOxf5wH yJDkU2NEmZ531vZN3FQBqZUglkUG/eXe8tmRgb8VxoDD5u2a/T+6To/aXZMvDkfZE3g8 JkMLY7UQNjsz+quKqIgStDh/NWERlJsz3c3y1bnOMOjcqsOz81oGFlctjnXCSaRfeDMW SMACO1gY5GAeIbCV/4vkjVVDEah4PD4QQMLnDJsExdXASyv/qLXbjPb0bgq1lCpOC1a9 OTrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=37wPUZzrX/ueT6NMg9kdHB6XHwPYogZuEw4uPuTq8sE=; b=j+d10HKPZPJB2yUTkTR9RA/VBfhQpINUcgw2CBwiVyyeQCBgfCFq3Dfpfeh4ODrfV8 o6CFJQC1FKOcU8lvpruaNqxBmRQ4ppTsSRYMOxwLFkRIGuKw5iP5+GG4Kv+BMevHziOW 4jf0AT+mPZDHJdNwA5BuBRkROlWJXsDFjEx9JGd0ia2hJ9j1Ir+BD2YyFn8tA7ADastf f5u6SMKRlAxIfIzWF1sPrQuQpcNsmL6J/OLLoMgECyB1DPz7GwgTqc9HGQ6VHxKdZMb0 ZeG6ve2Z7noJ8GabNG31wWgIrkwvDIJq1tVLGthAUiJbaaN7ieVj4wskvUZsp+CrN0D5 xzug== X-Gm-Message-State: AOAM533lTKV8Ez2Zv7RY/3t4uEiV0omlnUsarLfRnn90MHV1dzmHu2kR twE9QjHG1hWPwhBYlqJvFR1JGUoFL0sPOw== X-Received: by 2002:a17:906:fa81:: with SMTP id lt1mr4561267ejb.459.1600778200068; Tue, 22 Sep 2020 05:36:40 -0700 (PDT) Received: from [192.168.1.101] (abab42.neoplus.adsl.tpnet.pl. [83.6.165.42]) by smtp.gmail.com with ESMTPSA id r13sm10867936edo.48.2020.09.22.05.36.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2020 05:36:39 -0700 (PDT) Subject: Re: [PATCH -next] clk: qcom: Remove set but not used variable References: <3724370a-19da-d4c6-fa6a-245e5017869c@gmail.com> To: Li Heng , Andy Gross , Bjorn Andersson , mturquette@baylibre.com, sboyd@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, lkml From: Konrad Dybcio X-Forwarded-Message-Id: <3724370a-19da-d4c6-fa6a-245e5017869c@gmail.com> Message-ID: <710ed642-cafc-7a68-dfe7-f16b6a1f81e6@gmail.com> Date: Tue, 22 Sep 2020 14:36:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <3724370a-19da-d4c6-fa6a-245e5017869c@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is not the correct solution. I sent a proper fix here [1]. Please do not modify critical platform drivers without having tested them on real hardware (I don't see any Tested-by's?). Instead, file a bug report so that more people can take a look at this. If this got merged, it would have had to be reverted eventually anyway.. [1] https://patchwork.kernel.org/patch/11792407/ Konrad