Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Sep 2020 19:00:07 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Liu Shixin <liushixin2@huawei.com>
Cc:     Viresh Kumar <vireshk@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] pinctrl: spear: simplify the return expression of
 spear310_pinctrl_probe
Message-ID: <20200922133007.dx46iszynpjcm6oq@vireshk-i7>
References: <20200921082448.2591929-1-liushixin2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200921082448.2591929-1-liushixin2@huawei.com>
User-Agent: NeoMutt/20180716-391-311a52
Precedence: bulk

On 21-09-20, 16:24, Liu Shixin wrote:
> Simplify the return expression.
> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
>  drivers/pinctrl/spear/pinctrl-spear310.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/pinctrl/spear/pinctrl-spear310.c b/drivers/pinctrl/spear/pinctrl-spear310.c
> index 393b2b97d527..9d9facc4a6e4 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear310.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear310.c
> @@ -379,8 +379,6 @@ static const struct of_device_id spear310_pinctrl_of_match[] = {
>  
>  static int spear310_pinctrl_probe(struct platform_device *pdev)
>  {
> -	int ret;
> -
>  	spear3xx_machdata.groups = spear310_pingroups;
>  	spear3xx_machdata.ngroups = ARRAY_SIZE(spear310_pingroups);
>  	spear3xx_machdata.functions = spear310_functions;
> @@ -392,11 +390,7 @@ static int spear310_pinctrl_probe(struct platform_device *pdev)
>  
>  	spear3xx_machdata.modes_supported = false;
>  
> -	ret = spear_pinctrl_probe(pdev, &spear3xx_machdata);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return spear_pinctrl_probe(pdev, &spear3xx_machdata);
>  }
>  
>  static struct platform_driver spear310_pinctrl_driver = {

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh