Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/2] KVM: VMX: Clean up IRQ/NMI handling
To:     Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Josh Poimboeuf <jpoimboe@redhat.com>,
        Uros Bizjak <ubizjak@gmail.com>,
        Andi Kleen <ak@linux.intel.com>
References: <20200915191505.10355-1-sean.j.christopherson@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <4a6aaa8a-c62c-5f7c-da3e-14a68a835487@redhat.com>
Date:   Tue, 22 Sep 2020 15:38:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200915191505.10355-1-sean.j.christopherson@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15/09/20 21:15, Sean Christopherson wrote:
> Clean up KVM's handling of IRQ and NMI exits to move the invocation of the
> IRQ handler to a standalone assembly routine, and to then consolidate the
> NMI handling to use the same indirect call approach instead of using INTn.
> 
> The IRQ cleanup was suggested by Josh Poimboeuf in the context of a false
> postive objtool warning[*].  I believe Josh intended to use UNWIND hints
> instead of trickery to avoid objtool complaints.  I opted for trickery in
> the form of a redundant, but explicit, restoration of RSP after the hidden
> IRET.  AFAICT, there are no existing UNWIND hints that would let objtool
> know that the stack is magically being restored, and adding a new hint to
> save a single MOV <reg>, <reg> instruction seemed like overkill.
> 
> The NMI consolidation was loosely suggested by Andi Kleen.  Andi's actual
> suggestion was to export and directly call the NMI handler, but that's a
> more involved change (unless I'm misunderstanding the wants of the NMI
> handler), whereas piggybacking the IRQ code is simple and seems like a
> worthwhile intermediate step.
> 
> Sean Christopherson (2):
>   KVM: VMX: Move IRQ invocation to assembly subroutine
>   KVM: VMX: Invoke NMI handler via indirect call instead of INTn
> 
>  arch/x86/kvm/vmx/vmenter.S | 34 +++++++++++++++++++++
>  arch/x86/kvm/vmx/vmx.c     | 61 +++++++++++---------------------------
>  2 files changed, 51 insertions(+), 44 deletions(-)
> 

Queued, thanks.

Paolo