Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <alpine.DEB.2.22.394.2009221219560.2659@hadrien>
In-Reply-To: <alpine.DEB.2.22.394.2009221219560.2659@hadrien>
Reply-To: fdmanana@gmail.com
From:   Filipe Manana <fdmanana@gmail.com>
Date:   Tue, 22 Sep 2020 15:05:59 +0100
Message-ID: <CAL3q7H6e7gQWs9X-N4RMxK+UhZKHGxNmP0-q+B6x19uyH9TOwA@mail.gmail.com>
Subject: Re: [PATCH] btrfs: fix memdup.cocci warnings
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Filipe Manana <fdmanana@suse.com>,
        Chris Mason <chris.mason@fusionio.com>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>,
        linux-btrfs <linux-btrfs@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kbuild-all@lists.01.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 22, 2020 at 11:29 AM Julia Lawall <julia.lawall@inria.fr> wrote=
:
>
> From: kernel test robot <lkp@intel.com>
>
> fs/btrfs/send.c:3854:8-15: WARNING opportunity for kmemdup
>
>  Use kmemdup rather than duplicating its implementation
>
> Generated by: scripts/coccinelle/api/memdup.cocci
>
> Fixes: 28314eb24e6c ("btrfs: send, recompute reference path after orphani=
zation of a directory")
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Since this is not in Linus' tree yet, it can be folded in the original patc=
h.
David, can you do that when you pick it?

Btw, isn't the Fixes tag meant only for bug fixes? This is a pure
cleanup afaics.

Thanks.

> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/fdmanana/linux.gi=
t misc-next
> head:   28314eb24e6cb8124d1e5da2ef2ccb90ec44cc06
> commit: 28314eb24e6cb8124d1e5da2ef2ccb90ec44cc06 [2/2] btrfs: send, recom=
pute reference path after orphanization of a directory
> :::::: branch date: 17 hours ago
> :::::: commit date: 17 hours ago
>
>
>  send.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -3851,10 +3851,9 @@ static int refresh_ref_path(struct send_
>         char *name;
>         int ret;
>
> -       name =3D kmalloc(ref->name_len, GFP_KERNEL);
> +       name =3D kmemdup(ref->name, ref->name_len, GFP_KERNEL);
>         if (!name)
>                 return -ENOMEM;
> -       memcpy(name, ref->name, ref->name_len);
>
>         fs_path_reset(ref->full_path);
>         ret =3D get_cur_path(sctx, ref->dir, ref->dir_gen, ref->full_path=
);


--=20
Filipe David Manana,

=E2=80=9CWhether you think you can, or you think you can't =E2=80=94 you're=
 right.=E2=80=9D