Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3976965pxk; Tue, 22 Sep 2020 07:29:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl3Z/CHiCYcOsUkfXKmB1SkRWhLgD+jdFfA5Ikwd2+TiREUxDAm5WMpCeuXjOEbPSXPhg+ X-Received: by 2002:a17:906:3748:: with SMTP id e8mr5332386ejc.71.1600784951175; Tue, 22 Sep 2020 07:29:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600784951; cv=none; d=google.com; s=arc-20160816; b=mtK9OkVZAOe+kL0pWEBUdTB84DBJWJbNDa7EKPSIKfcN3jrfrvsFseK/wssoFuTVuR 4Wcly/MUMC5JEMBngMoYPCYqMo4agYZHJEyytA7bfTx06E4NRZh/akPi0rinxSLyEGdx 5HmDgpdJVsSKINFKv4IHsz/L/ipxH3rEmO7L8czjVgOBI5g2O/7j1uyvn/xYNbd853ka ulbDajSONSrpc1SszB1pzvmTeHmgO+FVX4RQiKa/5U18GNIy8RnVoB9zypkkB3ILFHLd AWW4c+hU24NET3EJvJGYQcmguIKYFPQYbcoYfmhFq++6GXZzWMEW24Fb9X4q9KejWpuM DfXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xMYIrgMQJUGvwx8MD95j4mDE8wEGPAXuITMW7afjQog=; b=DHMC9INdzD0M2SP3ZtVDbpHtCedp1xUE/YExjlQ8bkhSJw7oIF/zACUWUvEaqI32E1 RO0Bu7ef4p1TrSIDI24bj5eCR1tZsRF0MMht5XrefOtqstDmSZBPUxUEFdx/DCv1Zz08 mesj3YEgc3HSmNHWsbjEYRZs6jx8OPXcOOwfyV9SBgKKvdCFxJpQNtm2dW12UQf9hncg +LoVLCvjZ9Lo+IRHekIpu7hnGT3FTVYVovGcKo/KNU42CBZaQitWG5+rnCOvK+Gbwbe8 ZxWzh6b+br7nh32zwPLvrG2q6JOgWmYTg2kfHTlUr3sbnsjfng2tnfenjK+J5TnBVFDQ sqmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b+zh2DI3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si9790624eji.118.2020.09.22.07.28.47; Tue, 22 Sep 2020 07:29:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b+zh2DI3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbgIVOZR (ORCPT + 99 others); Tue, 22 Sep 2020 10:25:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:58782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbgIVOZQ (ORCPT ); Tue, 22 Sep 2020 10:25:16 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4659220C09; Tue, 22 Sep 2020 14:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600784716; bh=BjcEs/cyjGNFH4+Iv6NV3gAcUsMvzMLKmIq/2ekfuaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b+zh2DI3qvzE0CrDPaxWv1J4MDNlht5urMzZMCMsvYshQYFJf+FQXsNH27lu4xRcB f3cuz90yMYI+GgorDpgyxeX5rvT478Fr5iw2La3MMmh253JrUav8jT6zDe5gU1jQMV aU3Ffy4uZW/7goLBmKO7llVuQZEKM9l17TLr9pJY= Date: Tue, 22 Sep 2020 10:25:15 -0400 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sylwester Nawrocki , Krzysztof Kozlowski , Charles Keepax , patches@opensource.cirrus.com, alsa-devel@alsa-project.org Subject: Re: [PATCH AUTOSEL 5.8 03/20] ASoC: wm8994: Skip setting of the WM8994_MICBIAS register for WM1811 Message-ID: <20200922142515.GN2431@sasha-vm> References: <20200921144027.2135390-1-sashal@kernel.org> <20200921144027.2135390-3-sashal@kernel.org> <20200921150701.GA12231@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200921150701.GA12231@sirena.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 04:07:01PM +0100, Mark Brown wrote: >On Mon, Sep 21, 2020 at 10:40:10AM -0400, Sasha Levin wrote: > >> The WM8994_MICBIAS register is not available in the WM1811 CODEC so skip >> initialization of that register for that device. >> This suppresses an error during boot: >> "wm8994-codec: ASoC: error at snd_soc_component_update_bits on wm8994-codec" > >This is pretty much a cosmetic change - previously we were silently not >reading the register, this just removes the attempt to read it since we >added an error message in the core. Right, the only reason I took it is that error message - I find that bogus error messages have almost the same (bad) impact as real kernel bugs. I can drop it if you'd prefer. -- Thanks, Sasha