Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3988194pxk; Tue, 22 Sep 2020 07:44:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzNc47k2wyinQDUyT2eEaj9CQokRk11nMQFRo0dxTmyA6pycABDivK0l5rdJtyJaDga5QI X-Received: by 2002:a50:e44b:: with SMTP id e11mr4307045edm.73.1600785880513; Tue, 22 Sep 2020 07:44:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600785880; cv=none; d=google.com; s=arc-20160816; b=g4gz7L1KoW02Dhoc+AZB958KOQP035tbbow8kAVWxo+gBxPAoeIKkIv0hVbBbqhrI4 xLjisueTLquyEvz/8YfO8UYdufrBsaQZkSlc9cVHvMqcoKXKL1vS22jpQlxaRYOzI13Y 9VQ8nIeRZ6GpHVc1/qYZoZZ2xNzONJrMufyG0WxFuKDRirC1lSiYKty6kLDJx1MVmvbX /rn/6G6TIz4OFG9srqDrxdo1H7yQCq47F6pvrAByT+2rMmRlS+IVM+SrB8w7evwVYeBr aNyHwI6WVwUfviOwpAnPjlr9zImI2bpkDmQEVIU7P9alpaj/IFC+k7OzPD6H02/UcOcM /z8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=m1hM4c6dFFDnao7F9PZYKBupx4rTzbl45tccKtkOQjU=; b=HtXAHowkheLXXmIzcrXi+8MsKjlqL0JPcVBySZAbsJXU2uvrQP3cIBGS1Ku2gi7jUX NH/1DgTCGJWs9xil6e8cZ3MyZ/YN0XgNqD+XIYrE4kKlU+ep4VUy0ulsojCpi2RrSJAR gxeCBkSTlEDsPhdl7rUJjZKtLd0Et5Dv7AJdf6pBrSLKx4mGETQMLYNYYmuigPuit07V Q63cm9KMyDt8kAJn2G0m/Tv4PEeVPpLKruTEeuR77aIdKPLjcfKtN+ftTxzhDIpUHtkB kyM5eruwqbJ4u51zNQ2+rrH0EICDkZ++JIPARQbKWg4AZLBYv81gUu7YhRC9FhmZLkX0 PjEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VmuJKVX8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c8si11725875edn.87.2020.09.22.07.44.16; Tue, 22 Sep 2020 07:44:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VmuJKVX8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbgIVOnO (ORCPT + 99 others); Tue, 22 Sep 2020 10:43:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:37206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbgIVOnO (ORCPT ); Tue, 22 Sep 2020 10:43:14 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 884782395C; Tue, 22 Sep 2020 14:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600785794; bh=m1hM4c6dFFDnao7F9PZYKBupx4rTzbl45tccKtkOQjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VmuJKVX8oP36C9cT3aUT+BZ+z1eEDAm3kR764yQxu4qROx0SIWjH1yFmjoYMzg57W ViFCLl3xNJk57KtrYDbEGraAFYAOppbTA+wz4KCHULRmFtfyPP/uaUfCy2J33YXGOX FNiDelp7905draUXgZSWkW2KtL/9De70llt0R5fI= Date: Tue, 22 Sep 2020 15:42:21 +0100 From: Mark Brown To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sylwester Nawrocki , Krzysztof Kozlowski , Charles Keepax , patches@opensource.cirrus.com, alsa-devel@alsa-project.org Subject: Re: [PATCH AUTOSEL 5.8 03/20] ASoC: wm8994: Skip setting of the WM8994_MICBIAS register for WM1811 Message-ID: <20200922144221.GW4792@sirena.org.uk> References: <20200921144027.2135390-1-sashal@kernel.org> <20200921144027.2135390-3-sashal@kernel.org> <20200921150701.GA12231@sirena.org.uk> <20200922142515.GN2431@sasha-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gvPGo+RAdjC9O5ul" Content-Disposition: inline In-Reply-To: <20200922142515.GN2431@sasha-vm> X-Cookie: Love thy neighbor, tune thy piano. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gvPGo+RAdjC9O5ul Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 22, 2020 at 10:25:15AM -0400, Sasha Levin wrote: > On Mon, Sep 21, 2020 at 04:07:01PM +0100, Mark Brown wrote: > > This is pretty much a cosmetic change - previously we were silently not > > reading the register, this just removes the attempt to read it since we > > added an error message in the core. > Right, the only reason I took it is that error message - I find that > bogus error messages have almost the same (bad) impact as real kernel > bugs. The point is that the error message isn't present in stable kernels so there is no impact on any user visible behaviour. --gvPGo+RAdjC9O5ul Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9qDUwACgkQJNaLcl1U h9CjdAf+PXoDfp7834wZQ9f1rb79rWZspO34iLgtd2QfsiJLwuTe2hFDIKkdoXXU ajhzk5ZjNKGpRq9aid6yJWpRor0e3qn1fUDdJgavmPHoNnTQ6q1EKzHv6nDRMSWD doWsRBkTkSmignj73JlG9keOyvMgihQVIZSZSEafqIsKWYHXMwLE96Qghgt0hFDv DrDEz6xHrA4AhTGBEMvhQMy2rvU5O8AwfzyD+u2vD6j+ejy/Q3DdldGMhrPbNvB2 W4l2rheJ1a0km9anTOOUUYHDiDp7ttqpvzuDOB42lttBXk+jgLroxkcU4EKZrsuL nmlsEikx87yrqnX68TKTrlZGqoaxAg== =7xiC -----END PGP SIGNATURE----- --gvPGo+RAdjC9O5ul--