Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3998100pxk; Tue, 22 Sep 2020 07:59:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz08xWQv8CiJ2LJha9N8djK7UBsJ8nx5p6SOq7DZfIr0F8rYu6sDbJ/ZQR8OMdOoQWSnBuD X-Received: by 2002:a17:906:5008:: with SMTP id s8mr5662182ejj.408.1600786766904; Tue, 22 Sep 2020 07:59:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600786766; cv=none; d=google.com; s=arc-20160816; b=M8rVZS73aL7fn9VXfZEClvRpGKz6fqf0tku5QuINIeORYH5p7aM+zx1ktIJooAVryY /E4ciWVAIv+hKbv5kK9ss6Te9lFrV3weXu74FOv98nhoYVdCW1MinccRwoYNpiWohGvX df4DrmisciipcRmpR/2ovLijwnG8oedS6w99zcB9n0GcGDo/N/ZksKt/ctSSWG6A56ap 8BXuyFxjk9oyw1gPJDN6GkgUJsWDRPub8p6ysEABi1v+mjgNjPNu9uMlgDLZRN79ln2/ P+63yGJ2Jwk4KlrUrQgybVMxfii3TRqPui6AxKudKz6AED8dvmzNVTaykHpJfmoBvvcV OkRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AkuVE5shhkBcoGmUd/6iS/KMsZqZy8Vto5mmNjXj45M=; b=nXXiNZM04KbdbPN3O1dRt15c31YrzbhZa++muzfz0iUZiCO5OwV1ysE/nELRYi0An/ ibOL9NPLcrG5LCuUUF1xiM0zoHXe42Iv5c+4rpe6yoQdpn8ke4nIhRyUiEf4sL/jUp5w H3k9v0JZ8eLtWCkiqRf5oM0q3UkxSw4j+Slq+uXRTnqO9xoPj+uriUQONl+KFXYeCJsT Zf8Walvp06h0a9sfLA9o0R8nnvwchCKg4aj688VEOLq55Mw5B6kWZKLmLaIaZxgTMUIt 93gt1rhYuLMRktWUJYrETzt4U6wsLqlZwTrYV2oaIdrsOfzwc5ogpxNyjVIb5TzIDqDd ukSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XqU2M5rl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si10773354ejg.341.2020.09.22.07.59.03; Tue, 22 Sep 2020 07:59:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XqU2M5rl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726762AbgIVO5I (ORCPT + 99 others); Tue, 22 Sep 2020 10:57:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:43182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbgIVO5I (ORCPT ); Tue, 22 Sep 2020 10:57:08 -0400 Received: from dhcp-10-100-145-180.wdl.wdc.com (unknown [199.255.45.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5833B2395C; Tue, 22 Sep 2020 14:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600786627; bh=qgNyAecq4oxMx1KaA3J1BnvoQo/FK2H/JbyEW4SN8pk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XqU2M5rll9Q9dBJ5G1ByTbvHr6CQvompbhY9rSaF7xg+CDIRBpVaNfGXBfNQIwAC4 K7X1hf0hdWhByhKaaM+jUqgcfIL4j60YaAm8nojwvUMRjFX9MG6NGRk2c0l2bnzfe8 cRG5IQHFP1mRdbib5Q1mMRUfgtPs95wH/LP7ClG8= Date: Tue, 22 Sep 2020 07:57:05 -0700 From: Keith Busch To: Xianting Tian Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null Message-ID: <20200922145705.GA4035426@dhcp-10-100-145-180.wdl.wdc.com> References: <20200922062517.30031-1-tian.xianting@h3c.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200922062517.30031-1-tian.xianting@h3c.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit subject is a too long. We should really try to keep these to 50 characters or less. nvme-pci: fix NULL req in completion handler Otherwise, looks fine. Reviewed-by: Keith Busch