Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4125453pxk; Tue, 22 Sep 2020 10:52:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt7qihbihAWFzmNtOBOK1XQSxQIyWvXJ69mzdsm1FbyA2P1eZCH5oIKqNTLjSyi+Vh6jnA X-Received: by 2002:a17:906:8143:: with SMTP id z3mr6120175ejw.323.1600797128936; Tue, 22 Sep 2020 10:52:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600797128; cv=none; d=google.com; s=arc-20160816; b=O9rp5E00661d6o5EDbWgknMtUhpDn/yWPmVzWfEZvkKCVNPy0kTZkfh8KFgoUPEwVE cE3/vw95oYXJHbLq6F5DYhO2n8HGiWWiNl6WlAyKuspSD/c1NvqniUb0WdmlBujGuazt /rM3g6GqjF4ooUlNssKl4vaHSaD+52oBQWILXCqxwkalLTBDYihNUhR1KtFUBZY9/WSp LLE/DhVch+MaHryi+Z1orFZQkSxJbw5/NCDytXV1S4qy/QDeOKB2zdtJNdtP+vjX13RX dS629HNnnIMC/sfeQHrPdj4RIkL0l79cyW8a0JieDUG7PtLoc/XJliglu4pkEoaPM0HI I6ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=qVqxL2owg2kDSpSts9aypi+G5FFY2GmKeEfU085U83Y=; b=NomBmYBwPeu85t8VLvB/dXMoeVrHHySMEK0JDXxjRQqsP/4Ot3W6W1ttLWDdtGoSat KKpYCWLlfLXpWSxWIf94sxwMaLoXwgE4+XubbPBKu+UQ5FcvUgu/zVJ0nqKz/WkY6KcA cVd0td9XPmhCG5yIo6EPh9Qj/Mr67nHBlG3Gik1xvBHdQakdcFDcosLOjT6o/lOsh0g1 G0Lws13QAEb6q6chyjpebsmL1g96Gon6qTKcDu/bLnp8cD3B0OXKH67YpR7PE91xNVxO mPDg/m59hOZfLzRYdjsc7eRKDcEGXedpO+pp0iTNG6NxesICGOGIKdqRubvIwpn9eeK8 lLsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=KSIMJ50P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gw6si11261943ejb.240.2020.09.22.10.51.45; Tue, 22 Sep 2020 10:52:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=KSIMJ50P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726723AbgIVRuR (ORCPT + 99 others); Tue, 22 Sep 2020 13:50:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726573AbgIVRuR (ORCPT ); Tue, 22 Sep 2020 13:50:17 -0400 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52792C061755 for ; Tue, 22 Sep 2020 10:50:17 -0700 (PDT) Received: by mail-qt1-x844.google.com with SMTP id z2so16253274qtv.12 for ; Tue, 22 Sep 2020 10:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qVqxL2owg2kDSpSts9aypi+G5FFY2GmKeEfU085U83Y=; b=KSIMJ50P2g5c+zdsX3OlgRaXG4s9ZIitZhumJ4SRpbbXmLwqs/emuUBxlr5SP97yDg WVeWpTL14BeASFSREXxjK1skzELOW8DhwBsV5po53MEjXLAJOeVaejuHTfC/BSut8j8x 7PMKst/YNnQ7LGgSIPPxx1GLygEuNgnDvvy0eLj8a8HCG0G39gB17mL/67FwX+mg1G3F XayZDShHeAk5QkEXT3bcAMD8KklY/kKRT9RxzARRbWXuIyAzaWc7nWLqI/Ff0ZLUDd2P AE0FriiMcabZApft3bx43BIR6GXQK3y5CS83rXr41VP5afBrWQYyYhiUjD5RFTjgLcmr RYOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qVqxL2owg2kDSpSts9aypi+G5FFY2GmKeEfU085U83Y=; b=YQD9ud4ZlrIZsXtet5AlDSAbPdyrq4tm+KIPaF4baPq6pVMayfb2ImIxF4m0/fEr0+ HfYQDM1fYSL+42kS4fLUNXtKhjpVQbG9Qz90p3SPAXxRaIF6DBUxKrzJYwVJe1lfwPz6 o23wjpJZ+AUBWCdifwFRS23okElqON+kfFIyZxFEEzGsqPTfiAcEi3frLXb8JDxsKbBm Gt5HvN4GHLrhSRI4g6Hpc3lu1U02qjfuB+L6EDyq0ZIhypMXiUpPG1X1v29QgQmP2Dq/ tY0AGvovb76X8YbfQtfpl8OcKGf2uUy+L+2B5O2HnSzjutWleuTDAfOQ6TtD32pRrZo4 Tf6g== X-Gm-Message-State: AOAM532SyzVxvRGRCCvDzl5Qs/Usq38mT+tKZ3JX8S5exnWCV5AmSwj7 lQxPBYlYGhmKsXVzIHh0CSYnUtW1CW5tA64lsXq5cw== X-Received: by 2002:ac8:165d:: with SMTP id x29mr5734327qtk.117.1600797016466; Tue, 22 Sep 2020 10:50:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Francesco Ruggeri Date: Tue, 22 Sep 2020 10:50:05 -0700 Message-ID: Subject: Re: [PATCH 1/3] net: fix a new kernel-doc warning at dev.c To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , "David S. Miller" , Jonathan Corbet , Alexei Starovoitov , Andrii Nakryiko , Cong Wang , Eric Dumazet , Jakub Kicinski , Jiri Pirko , Taehee Yoo , open list , netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2020 at 4:22 AM Mauro Carvalho Chehab wrote: > > kernel-doc expects the function prototype to be just after > the kernel-doc markup, as otherwise it will get it all wrong: > > ./net/core/dev.c:10036: warning: Excess function parameter 'dev' description in 'WAIT_REFS_MIN_MSECS' > > Fixes: 0e4be9e57e8c ("net: use exponential backoff in netdev_wait_allrefs") > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Francesco Ruggeri Thanks for fixing this!