Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4236399pxk; Tue, 22 Sep 2020 14:04:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvxRFCh+x2h39y1ybIaHnT9mqLIIiQcgLwTrqzY/jbfcO4zbqE3EPDNzUmprNWhcGvvCqs X-Received: by 2002:a05:6402:144c:: with SMTP id d12mr6183004edx.168.1600808646464; Tue, 22 Sep 2020 14:04:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600808646; cv=none; d=google.com; s=arc-20160816; b=AhZ6H80Tw1XdDoWfheG3AycLmuK0x1YZgAdTS4oUTXzg1USegCT+noW4BekCkWmVzL NMERCpHLZ+atCDT5Ys5YaTP3YqCWXZh9EEWdE/I8mIh9h2MsVTTfeCKe0dU63ce7FVPp kTKJDFZiwIs3QDKOZTrtRscqdwZUoWaIZR6AVmibYAejDamWoix2/IfzZfhQUwm4GfSf exbeQQVzSAUaQxPZNQ+DmMj5SF+x/PQCNA+wiz8MKNqXBJ0niJfD36Tf2WSEhwLX8Ipm +SW48cCIS9ayWHp0FEao02Yabrw9OldIz11vBOeCYJtulAVeln7NIvtNvg/x5GC66K+w MV9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:ironport-sdr:ironport-sdr; bh=USPGNkpDs1QXjhNVy9R3XwUj6dhMLmDum2i8ePoljAg=; b=LoxGcS0/L+TzJae18+ycNSB38mNqUffjJM6muYuF7TNWYTL+sGY1KzDIBNLQe0zqqP MqqY+O+BFQFbR0iHo+pVgwzhz5C71DRCAfZjxNcpV6x3avlQDUTPs1xBd0zeDDekwfKA 6IGBIrHJ/bl/ZPkKqKMQn3XmsReoMGsO/RjYYflqTPD22fi8bX/mmZFTjWbUKQGz/qam UbwsWsJPIMDXM3tLb6mf8cgzUf5SnWXrWUi65wZBCAaEsgiKfFe3f+zI0xRtVH+pM/CT 7DUiV5J//kJwi5UCPhSyGjXz5jhlkGqc6USoqW/bH3c/166228NSEVI7yYuOKgA3j9l2 WCIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si10898304ejz.621.2020.09.22.14.03.41; Tue, 22 Sep 2020 14:04:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbgIVU7r (ORCPT + 99 others); Tue, 22 Sep 2020 16:59:47 -0400 Received: from mga01.intel.com ([192.55.52.88]:18525 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbgIVU7n (ORCPT ); Tue, 22 Sep 2020 16:59:43 -0400 IronPort-SDR: kufgDhAoszBOpk6FDOZ06iLfRddZNxakdQnhSfWUMNE1vnEKXaPf+sUJcGAfG2EYX03OCgA0yx mbBq1SgOzp+w== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="178786775" X-IronPort-AV: E=Sophos;i="5.77,292,1596524400"; d="scan'208";a="178786775" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 13:54:43 -0700 IronPort-SDR: hMGzXnr7sdnP8MVr8OUKm40bacifIWF1ItaAxo6j505XngtLs4c5NhP0HTdGvWuDOkKUEnbW+x mjtaJAveU9fg== X-IronPort-AV: E=Sophos;i="5.77,292,1596524400"; d="scan'208";a="510718948" Received: from fkhoshne-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.255.230.168]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 13:54:43 -0700 From: sathyanarayanan.kuppuswamy@linux.intel.com To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: [PATCH v9 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic Date: Tue, 22 Sep 2020 13:54:31 -0700 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuppuswamy Sathyanarayanan In DPC service enable logic, check for services & PCIE_PORT_SERVICE_AER implies pci_aer_available() is true. So there is no need to explicitly check it again. Also, passing pcie_ports=dpc-native in kernel command line implies DPC needs to be enabled in native mode irrespective of AER ownership status. So checking for pci_aer_available() without checking for pcie_ports status is incorrect. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/pci/pcie/portdrv_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 2c0278f0fdcc..e257a2ca3595 100644 --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -252,7 +252,6 @@ static int get_port_device_capability(struct pci_dev *dev) * permission to use AER. */ if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && - pci_aer_available() && (host->native_dpc || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC; -- 2.17.1