Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200915073213.12779-1-biwen.li@oss.nxp.com> <20200915073213.12779-2-biwen.li@oss.nxp.com>
 <20200922030208.GY25109@dragon> <DB6PR0401MB2438ABB1DFE785F9EAADB69E8F3B0@DB6PR0401MB2438.eurprd04.prod.outlook.com>
 <VE1PR04MB6687237BD5D137C4B9EC6DBD8F3B0@VE1PR04MB6687.eurprd04.prod.outlook.com>
 <DB6PR0401MB243883AEA75F615A0768D03E8F3B0@DB6PR0401MB2438.eurprd04.prod.outlook.com>
In-Reply-To: <DB6PR0401MB243883AEA75F615A0768D03E8F3B0@DB6PR0401MB2438.eurprd04.prod.outlook.com>
From:   Li Yang <leoyang.li@nxp.com>
Date:   Tue, 22 Sep 2020 17:28:43 -0500
Message-ID: <CADRPPNSiYnj+H4_CoKKQcT2ROM32XRVHqwGYMAvuTAheTsK2pQ@mail.gmail.com>
Subject: Re: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless
 property of rtc
To:     Biwen Li <biwen.li@nxp.com>, V.Sethi@nxp.com, peter.newton@nxp.com
Cc:     Shawn Guo <shawnguo@kernel.org>,
        "Biwen Li (OSS)" <biwen.li@oss.nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiafei Pan <jiafei.pan@nxp.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 21, 2020 at 10:56 PM Biwen Li <biwen.li@nxp.com> wrote:
>
> >
> >
> >
> > > -----Original Message-----
> > > From: Biwen Li <biwen.li@nxp.com>
> > > Sent: Monday, September 21, 2020 10:13 PM
> > > To: Shawn Guo <shawnguo@kernel.org>; Biwen Li (OSS)
> > > <biwen.li@oss.nxp.com>
> > > Cc: alexandre.belloni@bootlin.com; Leo Li <leoyang.li@nxp.com>;
> > > robh+dt@kernel.org; mark.rutland@arm.com; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>; linux-
> > > rtc@vger.kernel.org
> > > Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove
> > > useless property of rtc
> > >
> > > >
> > > > Caution: EXT Email
> > > >
> > > > On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > > > > From: Biwen Li <biwen.li@nxp.com>
> > > > >
> > > > > Remove useless property interrupts of rtc
> > > > >
> > > > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > > > ---
> > > > >  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > > > >  1 file changed, 2 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > index dce79018d397..e9e982176e07 100644
> > > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > @@ -171,8 +171,6 @@
> > > > >       rtc@51 {
> > > > >               compatible = "nxp,pcf2129";
> > > > >               reg = <0x51>;
> > > > > -             // IRQ10_B
> > > > > -             interrupts = <0 150 0x4>;
> > > >
> > > > If it's a correct description of hardware, I do not see why we would
> > > > need to remove it.
> > > Hi Shawn,
> > >
> > > Don't need use the interrupt, only read time from rtc.
> >
> > User probably will choose to use the alarm feature of the RTC and need the
> > interrupt property.  Is there any issue when the interrupt property is present?
> Generic interrupt controller on layerscape only support  IRQ_TYPE_LEVEL_HIGH and  IRQ_TYPE_EDGE_RISING(except SoC LS1043A, LS1046A),
> Not support IRQ_TYPE_LEVEL_LOW,

That is not true.  Although the GIC SPI only deals with level high and
rising edge, there is a separate IRQCR register on LX2160 that can
invert external interrupt.  If the current LX2160 code doesn't support
that, we need to fix it.  Adding Varun for this.  We probably can
extend the existing drivers/irqchip/irq-ls-extirq.c driver to support
LX2160.

And btw, the interrupt number 150 is obviously wrong too.  We probably
can remove it temporarily before the external interrupt is properly
supported on lx2160.

> In drivers/rtc/rtc-pcf2127.c
> ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
> pcf2127_rtc_irq,
> IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> dev_name(dev), dev);
>
> >
> > >
> > > Best Regards,
> > > Biwen Li
> > > >
> > > > Shawn
> > > >
> > > > >       };
> > > > >  };
> > > > >
> > > > > --
> > > > > 2.17.1
> > > > >