Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: pi0alN4S+u2c4lzqRoOSEevoVYcQ2eltmlI7eUp2haEPTJhObtcVeTNcuojzz9cS1MTUWUkdDp
 yh3eEXJXgWupcIzod3xsB0AXksUYexh317dOHj27vVoepFnH+pBqNJtIRlbeo7gGyUrkk0b8In
 W3C3qk5mTFMVx02gE8epLRqjTsTuaSZwt//EgimesmanbAqRTYSAYOLBJ/gV685aGwDokRFaO9
 Frj6SobiI+uNdtMMw2XhfAzOrqL1zzWt/zdFSmYotncK2HR9m3u5hPIIlFiMtyk0nX1VVfivu1
 kLk=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Sasha Levin <sashal@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
CC:     Palmer Dabbelt <palmerdabbelt@google.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH AUTOSEL 5.8 20/20] riscv: Fix Kendryte K210 device tree
Thread-Topic: [PATCH AUTOSEL 5.8 20/20] riscv: Fix Kendryte K210 device tree
Thread-Index: AQHWkCU53Yt83wGZ7keUFBY/2Egj+g==
Date:   Wed, 23 Sep 2020 00:27:42 +0000
Message-ID: <CY4PR04MB3751BE40C3EC0BD2F392E9EEE7380@CY4PR04MB3751.namprd04.prod.outlook.com>
References: <20200921144027.2135390-1-sashal@kernel.org>
 <20200921144027.2135390-20-sashal@kernel.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 16895b07-74c7-49cf-dc1a-08d85f577c8b
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 00:27:42.6230
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2wDChNX9KNFM0OWBSh35Ua8GXznxxyW6IRsgTOL7MRStf8ZQ/g6IyU/+1KUEJt3tjXjcSQ1Zuj1fPEo2ysb+Qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB0968
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/09/21 23:41, Sasha Levin wrote:=0A=
> From: Damien Le Moal <damien.lemoal@wdc.com>=0A=
> =0A=
> [ Upstream commit f025d9d9934b84cd03b7796072d10686029c408e ]=0A=
> =0A=
> The Kendryte K210 SoC CLINT is compatible with Sifive clint v0=0A=
> (sifive,clint0). Fix the Kendryte K210 device tree clint entry to be=0A=
> inline with the sifive timer definition documented in=0A=
> Documentation/devicetree/bindings/timer/sifive,clint.yaml.=0A=
> The device tree clint entry is renamed similarly to u-boot device tree=0A=
> definition to improve compatibility with u-boot defined device tree.=0A=
> To ensure correct initialization, the interrup-cells attribute is added=
=0A=
> and the interrupt-extended attribute definition fixed.=0A=
> =0A=
> This fixes boot failures with Kendryte K210 SoC boards.=0A=
> =0A=
> Note that the clock referenced is kept as K210_CLK_ACLK, which does not=
=0A=
> necessarilly match the clint MTIME increment rate. This however does not=
=0A=
> seem to cause any problem for now.=0A=
> =0A=
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>=0A=
> Signed-off-by: Sasha Levin <sashal@kernel.org>=0A=
> ---=0A=
>  arch/riscv/boot/dts/kendryte/k210.dtsi | 6 ++++--=0A=
>  1 file changed, 4 insertions(+), 2 deletions(-)=0A=
> =0A=
> diff --git a/arch/riscv/boot/dts/kendryte/k210.dtsi b/arch/riscv/boot/dts=
/kendryte/k210.dtsi=0A=
> index c1df56ccb8d55..d2d0ff6456325 100644=0A=
> --- a/arch/riscv/boot/dts/kendryte/k210.dtsi=0A=
> +++ b/arch/riscv/boot/dts/kendryte/k210.dtsi=0A=
> @@ -95,10 +95,12 @@ sysctl: sysctl@50440000 {=0A=
>  			#clock-cells =3D <1>;=0A=
>  		};=0A=
>  =0A=
> -		clint0: interrupt-controller@2000000 {=0A=
> +		clint0: clint@2000000 {=0A=
> +			#interrupt-cells =3D <1>;=0A=
>  			compatible =3D "riscv,clint0";=0A=
>  			reg =3D <0x2000000 0xC000>;=0A=
> -			interrupts-extended =3D <&cpu0_intc 3>,  <&cpu1_intc 3>;=0A=
> +			interrupts-extended =3D  <&cpu0_intc 3 &cpu0_intc 7=0A=
> +						&cpu1_intc 3 &cpu1_intc 7>;=0A=
>  			clocks =3D <&sysctl K210_CLK_ACLK>;=0A=
>  		};=0A=
>  =0A=
> =0A=
=0A=
Sasha,=0A=
=0A=
This is a fix for a problem in 5.9 tree. 5.8 kernel is fine without this pa=
tch.=0A=
And I think applying it to 5.8 might actually break things since the proper=
=0A=
clint driver was added to kernel 5.9 and does not exist in 5.8.=0A=
=0A=
Best regards.=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=