Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp43513pxk; Tue, 22 Sep 2020 18:04:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyERqcIMZ1LyG9XLtK3Su7D+MaeZExs8hC0QZA8wCnr0knPtEgkyaR+P2jUvB9swvfnQa8Y X-Received: by 2002:a05:6402:1012:: with SMTP id c18mr6869473edu.77.1600823080425; Tue, 22 Sep 2020 18:04:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600823080; cv=none; d=google.com; s=arc-20160816; b=Zgfki7DCGMK5ismFa78Z6UTbPAfVzzDky6q+Bx3cHe1ZLCr24+4kQBiHmkXkBSBoUx wIKk+aINCPe/reW8yKwhbauxqbdxUiVEDjcEAJ/rgC7Qnph9hQkmuAPFy1tQsrI5hVbB bo3Es1N2ohkbnLwMspSYkwQSOw2vBq93KYXKPGZxoCmgxy+tXfqWSHkYPBydAvBu/4jK k7YbNWFuB6Ejjq3QXAtYCGqoZ1A2gIbKKUai+639YFuqPM6mp7kuwNeKQK+fBidjDhRV XBur/hv90Qe9f2uggHLmsaeOyBAjK1E31nbBZPZUBJcJxxm+hYUVvgJsyo8/LFrWUc+U WcbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=p4AKAKCBmfCn4yWHVUiNN9DjkVKaWkjjVtV3bQAGiMs=; b=EINGSFtnhZpOG46zuqLYT7HvnW0MS3JXinNk0y8pHwd5q732eIDlrJBYRy8wp38lpH kDL+f/zs2UG+bYSS4v+Vr31FuDhPLDTXyw+qxVeAgwB85KDTYA4TwTAzhoU1UD1NrM0U 7MjFS0TLjy8GzJQxlu9rVi8RV8TEsW3UXZ1XT+1x8Ccw9AGIdm6M+lpMZQgtCfIlcfGI oO2ESyYtKGmqZWU3oy52t+na/JNzTgLEmR/uuVYup97BNlchg8DbhN4FNjTN/+yec+yZ WV5+PO3UYfNi72wkvnopLp6n/q2sgY9kLprIM/o1D8azjtzR/FDzAiMLEr/NGCik7Lkv wMDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b="TvX//jms"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si12015987edy.400.2020.09.22.18.04.17; Tue, 22 Sep 2020 18:04:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b="TvX//jms"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgIWA30 (ORCPT + 99 others); Tue, 22 Sep 2020 20:29:26 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:49504 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbgIWA30 (ORCPT ); Tue, 22 Sep 2020 20:29:26 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08N0Ss4D100635; Wed, 23 Sep 2020 00:29:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=p4AKAKCBmfCn4yWHVUiNN9DjkVKaWkjjVtV3bQAGiMs=; b=TvX//jmsCz6mMHRL6054fB80aSfMZfnak9sINRf/580oI+r/WsDAJb+dGKodJb9bd0N6 sjbGcWMy6vjMcJ/OhDlvZuXHYbTk0w9gLRLewwyAZBpY06Yp4vkz1VUvmzc9pEAera0l cLAYi3l4xfD3V7Uc6T4uHe2/trmcGhgUEXqxQJEtvlaXAZl2Y1s23wWNaJtz0WQlbQFg CLGL6K6fUhin/26xn+nIP+6YmSGjpXGKWI1Ycqz3pqtnt7td7Z7mSDywcj9BJCN3mQCJ d/CWzmvfbc2xqLTGifJ/ja2chGfcbS6ENLhijK16qqC9clh3++XFEzD7vjzVa51cV5zJ QA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 33ndnufrev-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 23 Sep 2020 00:29:09 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08N0Pbc8057119; Wed, 23 Sep 2020 00:29:09 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 33nux08myg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2020 00:29:08 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08N0T6Hr015119; Wed, 23 Sep 2020 00:29:06 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 Sep 2020 17:29:06 -0700 To: Qinglang Miao Cc: Nilesh Javali , Manish Rangankar , , "James E.J. Bottomley" , "Martin K. Petersen" , , Subject: Re: [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200916062133.191000-1-miaoqinglang@huawei.com> Date: Tue, 22 Sep 2020 20:29:03 -0400 In-Reply-To: <20200916062133.191000-1-miaoqinglang@huawei.com> (Qinglang Miao's message of "Wed, 16 Sep 2020 14:21:33 +0800") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 suspectscore=1 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009230000 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=1 bulkscore=0 clxscore=1011 impostorscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009230000 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Qinglang, > The mutex bnx2i_dev_lock is initialized statically. It is > unnecessary to initialize by mutex_init(). Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering