Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp54850pxk; Tue, 22 Sep 2020 18:29:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwV9HclQKrF15a9GGfJI+J7bbJ546oUZ4+8qb8WVGqBu1xY+HWIQqTFAnJIt6plk4i8u6H X-Received: by 2002:a17:906:6ce:: with SMTP id v14mr7608484ejb.451.1600824546776; Tue, 22 Sep 2020 18:29:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600824546; cv=none; d=google.com; s=arc-20160816; b=mTF7XIot1u+c91o6+X//BNj/AngFUpP2y0ZH+Sit78h6kJHDDLrM8jzeAPitaOxs6e Q0dXe72iS2l9L9uFRiEp02A4NTnba7tGtFH+q90gFZsbj5CLdBrGOtwHXxqOR7G4wBtx uMZV72XC7gqwOBook1viSL6N98iBWWWvHG4BmPbtvavFXB3LmkC9c+Ta+AGEBRtQJ/Q5 OpO/tMlhvMaKxRLtIl2vjWsvKJbQm131vYnS+F8T25xqTSRj05PurvuecgsCStmQjXxm oYV26k3QzRxgXCDPI5nW+OYRmUwhKz8RlzIYL1PcDyq3PxqbiPhAD3BiVe5jNDo+6eXn pilw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=PEFV58UGy2QfwixXMWPDSa2Z2Nxo9LcgkAGEPp0JT9s=; b=bMihiHVJY4wnm4CEgzT0qXoGfUgy/MJNwLWI5/FlE9kYI+Wc0DW70CrAdKk7MsD4Ii nw4gUsGXkLqptAfOv3qrmE5osMMqkw+i9P7auqzd387R+omAVos1hxlTZlLg5UOu4G5R 44FIZkboFdxDqKoen3SPn9uu6yY6JgNulhyClknsB63MDWxDeQMwpuMBONjzovUYX/JQ QRMfaRvTI8f1exmBA4ix+6XwV/tiSFWJ/XQwodDreeF0EWzWtfGSL1ncFw6kv6YU1386 FfDBZ2ywPpXxXalECPx+E06wZcHh9XU7vJG6DQ7RFat2SyowMhUWqUCFr4Dzp1siqN9W gD8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Y1BcM9Nc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gj23si13511818ejb.419.2020.09.22.18.28.43; Tue, 22 Sep 2020 18:29:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Y1BcM9Nc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727128AbgIWAaS (ORCPT + 99 others); Tue, 22 Sep 2020 20:30:18 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:48280 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727123AbgIWAaR (ORCPT ); Tue, 22 Sep 2020 20:30:17 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08N0TlIr162312; Wed, 23 Sep 2020 00:29:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=PEFV58UGy2QfwixXMWPDSa2Z2Nxo9LcgkAGEPp0JT9s=; b=Y1BcM9Ncp5O7V1nFGXx3O2xRdwfGuJ0hZQHkXa/cFNfNhLKgyqTfOwdvr/AqSJcFs0Sy DOjs7kp7lK9BlAGHWRBKQt3de7KssWDX27bXpUt4cdz3Y9lDgrMN9A7hd6A0AyIa/7e4 0Aeibd2U61sR+J28Wn/E3p7ndJ6s9h2beztH9mVN1YUCAF9UhMpLhJAhl/xmpeuZ6w/q cB5Rs9meMlZpoZxNqRfr5fBjsxXCZlCcuJz7KmLyykL5VwjU4SfNAnFdp2CjO8JjGwP0 S+RQ3zPJ4xhjP8il25iYrpV3I9Qwb6KJj1f2jAuhi/VYo/LA73PyF8SeN5/1FNSlxYKC aw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 33qcptvmsx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 23 Sep 2020 00:29:47 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08N0QY2w163057; Wed, 23 Sep 2020 00:29:46 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33nujnwetc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Sep 2020 00:29:46 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08N0Tifn030627; Wed, 23 Sep 2020 00:29:44 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 Sep 2020 17:29:43 -0700 To: Jing Xiangfeng Cc: , , , , , , , Subject: Re: [PATCH] scsi: remove redundant initialization of variable ret From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200918090747.44645-1-jingxiangfeng@huawei.com> Date: Tue, 22 Sep 2020 20:29:41 -0400 In-Reply-To: <20200918090747.44645-1-jingxiangfeng@huawei.com> (Jing Xiangfeng's message of "Fri, 18 Sep 2020 17:07:47 +0800") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 adultscore=0 spamscore=0 suspectscore=1 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009230000 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9752 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 mlxlogscore=999 adultscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 clxscore=1011 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009230000 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jing, > The variable ret is being initialized with '-ENOMEM' that is > meaningless. So remove it. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering