Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 22 Sep 2020 21:48:38 -0400
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc:     Kamel Bouhara <kamel.bouhara@bootlin.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: microchip-tcb-capture: Constify mchp_tc_ops
Message-ID: <20200923014838.GA3267@shinobu>
References: <20200922201941.41328-1-rikard.falkeborn@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW"
Content-Disposition: inline
In-Reply-To: <20200922201941.41328-1-rikard.falkeborn@gmail.com>
Precedence: bulk


--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 22, 2020 at 10:19:41PM +0200, Rikard Falkeborn wrote:
> The only usage of mchp_tc_ops is to assign its address to the ops field
> in the counter_device struct which is a const pointer. Make it const to
> allow the compiler to put it in read-only memory.
>=20
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
>  drivers/counter/microchip-tcb-capture.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/mi=
crochip-tcb-capture.c
> index b7b252c5addf..039c54a78aa5 100644
> --- a/drivers/counter/microchip-tcb-capture.c
> +++ b/drivers/counter/microchip-tcb-capture.c
> @@ -253,7 +253,7 @@ static struct counter_count mchp_tc_counts[] =3D {
>  	},
>  };
> =20
> -static struct counter_ops mchp_tc_ops =3D {
> +static const struct counter_ops mchp_tc_ops =3D {
>  	.signal_read  =3D mchp_tc_count_signal_read,
>  	.count_read   =3D mchp_tc_count_read,
>  	.function_get =3D mchp_tc_count_function_get,
> --=20
> 2.28.0
>=20

--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl9qqVQACgkQhvpINdm7
VJKiUA//RCxl+1lEl3ZD7fgozAxc91BtR5k9Yu6UGBtrLNE+0lxJmpOdGyuN0K6X
iqXNMEzyJWvydI5+K/2GUvBrzQRIiufVyeTd8aUygFtJh+8Qysa3fmHrVJz/6SSA
TUKnENMoNKZZi9IzdGRkZN0yXr25RCVT6WXpb21T6Xp3nTAVTDU3GNNB5ytHhArG
AmT2iiNb5qX1fGfzG9jP9S6pf4bVhP5po4cwAWsLbziJTuNvfnp+ByMn3xx+UUw7
JN9WEm6/H36DTO0qNpNP6azWPLyZk8vElHY6tKpDKBvhN5k6UaJ6EXpvbba7DntA
+xgQUAxfE6txDv20uwF/w4CdTdXI0tOBdBhv5Av+naWhu9LFG7n0wveOIF9L0ZXI
KqYZ+ZSV537vZtvych1izHjm6V+LDmm49K6OhJnBkjYp4N36gmNhUbPV8UKhIh5E
UlVyf4eqllRqmzkVwuma/kb6BM6XUKue8lp0vZjovcMXHeTQ4YumYnh7E7igqLWz
V19MlFTEQrzR9h2B0LXbXkzXZm/fAnNQu00YSrOpNJ8Yl9gAIziTWWDxCDsYFORn
eFxRHF5bvisS6srCGTF2JZuAmH3WC+Dgo33OzGCBVgzOP9ZQ7FoSLf2HpIqT7Dgh
mysWnBNBXI9E1L+nNWWiYLpykO9Fru8nuG8cMKc9k/2mcnR/ISI=
=AK/t
-----END PGP SIGNATURE-----

--ew6BAiZeqk4r7MaW--