Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp90783pxk; Tue, 22 Sep 2020 19:57:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSpgm3SckLel4woz7savYcWZzo4FY+sJJFrNtPJP5YAVps9bqfovkmztLXZ5luxrMu3RvK X-Received: by 2002:aa7:df14:: with SMTP id c20mr7371225edy.334.1600829832415; Tue, 22 Sep 2020 19:57:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600829832; cv=none; d=google.com; s=arc-20160816; b=YKPtgZ0mAOkV8psS8pRvPQDBmxcxeL0Xr35EtwOw+HTGL0lVPhQ8iaVJwxW+jlnmgm 9/BK4bF/1azo1bi7PeK8fwm4sYu4mACucIIY13vSRly48312cw9dbKtvLZqOhU2PBccP bzuqWaD87aT/VQsg6rIEFNtTfEFcizNfnVhmK93NMNoIakaLJR/amHe8+0tVHxmgs5mb 3auyAxpDuMu5k99ZzLbr+pKMMNj3AsBzhCRO9LzLuewL/xLFcVlwVBhezPX2DoK3Fmuw 8qB9TUWJCRd7Sbff4NFj3CgIXWjGqLixI66zP/gEC5ghLTdoylwqC0aAdfOUyZPAycEu qfTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jcbHe1IrJ08dD3pLDVVxZGARehBKkFryFjVeni9A5jw=; b=WZYAOL1wDEM99GiNmvSjwaP3ZPH6zud7SICvizxnRGd0H38JbARR00zhQvWj/VVdKf KXIFNvgrqm+x1rDAd/xGMY6o2RkBESoTn8VFUpvV+awA8UqZfXuJk/s6aMSRmcPdNLrN ejhiYw9dm0QbmKuAtefLnNDtxBtyTjfkrhHqkXSKUZwfBRRuLPPsSGB4HruBS8/g4NBG BHJ7/ZHljndagwauUls0/JdNlCH+bTAzPYjSV7a9UzPNYnYdnKeChoYGmcaW8psSNoKj T8hT93rVzdIss1gTJ046/qIacpIB732EbN3282OhNZDPNatbv7Mf6AHTerLKbVrD1Xr/ i5+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d15si12033573ejr.178.2020.09.22.19.56.49; Tue, 22 Sep 2020 19:57:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbgIWCH5 (ORCPT + 99 others); Tue, 22 Sep 2020 22:07:57 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14262 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726743AbgIWCH5 (ORCPT ); Tue, 22 Sep 2020 22:07:57 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id ED42D5D3707A01EE135B; Wed, 23 Sep 2020 10:07:54 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 23 Sep 2020 10:07:46 +0800 From: Jing Xiangfeng To: CC: , , Subject: [PATCH -next] virtiofs: Move the assignment to ret outside the loop Date: Wed, 23 Sep 2020 10:07:55 +0800 Message-ID: <20200923020755.187255-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to do the assignment each time. So move the assignment to ret outside the loop. Signed-off-by: Jing Xiangfeng --- fs/fuse/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c index e394dba08cc4..f18cd7b53ec7 100644 --- a/fs/fuse/dax.c +++ b/fs/fuse/dax.c @@ -1259,9 +1259,9 @@ static int fuse_dax_mem_range_init(struct fuse_conn_dax *fcd) pr_debug("%s: dax mapped %ld pages. nr_ranges=%ld\n", __func__, nr_pages, nr_ranges); + ret = -ENOMEM; for (i = 0; i < nr_ranges; i++) { range = kzalloc(sizeof(struct fuse_dax_mapping), GFP_KERNEL); - ret = -ENOMEM; if (!range) goto out_err; -- 2.26.0.106.g9fadedd