Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Subject: Re: [PATCH -next] powerpc/perf: Fix symbol undeclared warning
From:   Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <20200921112557.85471-1-wangwensheng4@huawei.com>
Date:   Wed, 23 Sep 2020 07:48:22 +0530
Cc:     Michael Ellerman <mpe@ellerman.id.au>, benh@kernel.crashing.org,
        paulus@samba.org, Madhavan Srinivasan <maddy@linux.ibm.com>,
        kajoljain <kjain@linux.ibm.com>,
        "anju@linux.vnet.ibm.com" <anju@linux.vnet.ibm.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <931F16F9-CE90-40B8-A69D-B75E80BF5DE5@linux.vnet.ibm.com>
References: <20200921112557.85471-1-wangwensheng4@huawei.com>
To:     Wang Wensheng <wangwensheng4@huawei.com>
Precedence: bulk


> On 21-Sep-2020, at 4:55 PM, Wang Wensheng <wangwensheng4@huawei.com> =
wrote:
>=20
> Build kernel with `C=3D2`:
> arch/powerpc/perf/isa207-common.c:24:18: warning: symbol
> 'isa207_pmu_format_attr' was not declared. Should it be static?
> arch/powerpc/perf/power9-pmu.c:101:5: warning: symbol 'p9_dd21_bl_ev'
> was not declared. Should it be static?
> arch/powerpc/perf/power9-pmu.c:115:5: warning: symbol 'p9_dd22_bl_ev'
> was not declared. Should it be static?

Hi,=20

It will be good to include a comment in the commit message saying what =
is the fix here.=20
ex, declare p9_dd21_bl_ev/p9_dd22_bl_ev as static variable.

Thanks
Athira
>=20
> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
> ---
> arch/powerpc/perf/isa207-common.c | 2 +-
> arch/powerpc/perf/power9-pmu.c    | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/powerpc/perf/isa207-common.c =
b/arch/powerpc/perf/isa207-common.c
> index 964437adec18..85dc860b265b 100644
> --- a/arch/powerpc/perf/isa207-common.c
> +++ b/arch/powerpc/perf/isa207-common.c
> @@ -21,7 +21,7 @@ PMU_FORMAT_ATTR(thresh_stop,	"config:32-35");
> PMU_FORMAT_ATTR(thresh_start,	"config:36-39");
> PMU_FORMAT_ATTR(thresh_cmp,	"config:40-49");
>=20
> -struct attribute *isa207_pmu_format_attr[] =3D {
> +static struct attribute *isa207_pmu_format_attr[] =3D {
> 	&format_attr_event.attr,
> 	&format_attr_pmcxsel.attr,
> 	&format_attr_mark.attr,
> diff --git a/arch/powerpc/perf/power9-pmu.c =
b/arch/powerpc/perf/power9-pmu.c
> index 2a57e93a79dc..4a315fad1f99 100644
> --- a/arch/powerpc/perf/power9-pmu.c
> +++ b/arch/powerpc/perf/power9-pmu.c
> @@ -98,7 +98,7 @@ extern u64 PERF_REG_EXTENDED_MASK;
> /* PowerISA v2.07 format attribute structure*/
> extern struct attribute_group isa207_pmu_format_group;
>=20
> -int p9_dd21_bl_ev[] =3D {
> +static int p9_dd21_bl_ev[] =3D {
> 	PM_MRK_ST_DONE_L2,
> 	PM_RADIX_PWC_L1_HIT,
> 	PM_FLOP_CMPL,
> @@ -112,7 +112,7 @@ int p9_dd21_bl_ev[] =3D {
> 	PM_DISP_HELD_SYNC_HOLD,
> };
>=20
> -int p9_dd22_bl_ev[] =3D {
> +static int p9_dd22_bl_ev[] =3D {
> 	PM_DTLB_MISS_16G,
> 	PM_DERAT_MISS_2M,
> 	PM_DTLB_MISS_2M,
> --=20
> 2.25.0
>=20