Subject: Re: [PATCH] memory hotadd fixes [1/5] not-aligned memory hotadd
	handling fix
From: keith mannthey <kmannth@us.ibm.com>
Reply-To: kmannth@us.ibm.com
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
       KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
       lkml <linux-kernel@vger.kernel.org>,
       lhms-devel <lhms-devel@lists.sourceforge.net>
In-Reply-To: <20060803163302.6D84.Y-GOTO@jp.fujitsu.com>
References: <20060803123039.c50feb85.kamezawa.hiroyu@jp.fujitsu.com>
	 <20060802233802.8186eb38.akpm@osdl.org>
	 <20060803163302.6D84.Y-GOTO@jp.fujitsu.com>
Content-Type: text/plain
Organization: Linux Technology Center IBM
Date: Thu, 03 Aug 2006 11:29:56 -0700
Message-Id: <1154629797.5925.21.camel@keithlap>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1563
Lines: 35

On Thu, 2006-08-03 at 16:47 +0900, Yasunori Goto wrote:
> > > After Keith's report of memory hotadd failure, I increased test patterns.
> > > These patches are a result of new patterns. But I cannot cover all existing
> > > memory layout in the world, more tests are needed.
> > > Now, I think my patch can make things better and want this codes to be tested
> > > in -mm.patche series is consitsts of 5 patches.
> > 
> > I expect the code which these patches touch is completely untested in -mm, so
> > all we'll get is compile testing and some review.
> > 
> > Given that these patches touch pretty much nothing but the memory hot-add
> > paths I'd be inclined to fast-track them into 2.6.18.  Do you agree that
> > these patches are sufficiently safe and that the problems that they solve
> > are sufficiently serious for us to take that approach?
> > 
> > Either way, could I ask that interested parties review this work closely
> > and promptly?
> 
> Hmm. I reviewed them a bit, and I couldn't find any problems.
> 
> However, my ia64 box is same of his. And emulation environment is very
> close too. So, my perspective must be very similar from him.
> I think my review is not enough. Keith-san's test is better if he can.
> 

I will test and review these patches today and will report back.  

Thanks,
  Keith

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/