Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 23 Sep 2020 09:37:26 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Drew Fustini <drew@beagleboard.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Jason Kridner <jkridner@beagleboard.org>,
        Robert Nelson <robertcnelson@gmail.com>,
        Trent Piepho <tpiepho@gmail.com>,
        Christina Quast <cquast@hanoverdisplays.com>,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am335x: guardian: switch to AM33XX_PADCONF
Message-ID: <20200923063726.GO7101@atomide.com>
References: <20200919195159.3126193-1-drew@beagleboard.org>
 <20200921064707.GN7101@atomide.com>
 <20200921095912.GA3752675@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200921095912.GA3752675@x1>
Precedence: bulk

* Drew Fustini <drew@beagleboard.org> [200921 09:59]:
> On Mon, Sep 21, 2020 at 09:47:07AM +0300, Tony Lindgren wrote:
> > * Drew Fustini <drew@beagleboard.org> [200919 19:53]:
> > > Change the pin defintions from AM33XX_IOPAD to AM33XX_PADCONF macro so
> > > that it correctly handles changes to #pinctrl-cells.
> > 
> > Thanks for fixing this. I wonder if we should now also change the define
> > for the old AM33XX_IOPAD macro?
> > 
> > Or just remove it completely and mention that we've changed nr-pinctrl-cells
> > to use 3 now?
> > 
> > Otherwise the unknown number of out-of-tree boards will be hitting this
> > too.
> > 
> 
> Christina Quast commented in f1ff9be7652b ("ARM: dts: am33xx: Added 
> AM33XX_PADCONF macro") that AM33XX_IOPAD() was left in place to avoid
> breaking boards not in mainline.
> 
> If we follow that logic, then I think that fixing AM33XX_IOPAD() for
> #pinctrl-cells = <2> would be the correct solution.
> 
> Would this be acceptable?
> 
> #define AM33XX_IOPAD(pa, val)          OMAP_IOPAD_OFFSET((pa), 0x0800) (val) (0)

Makes sense to me yeah.

Tony