Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] crypto: sa2ul: Fix DMA mapping API usage
To:     Christoph Hellwig <hch@infradead.org>
CC:     <herbert@gondor.apana.org.au>, <t-kristo@ti.com>,
        <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <j-keerthy@ti.com>
References: <20200921113846.6973-1-peter.ujfalusi@ti.com>
 <20200923060246.GA11550@infradead.org>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <593d5f9d-0629-f01d-4c67-112fc088bb4b@ti.com>
Date:   Wed, 23 Sep 2020 10:48:36 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200923060246.GA11550@infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 23/09/2020 9.02, Christoph Hellwig wrote:
> On Mon, Sep 21, 2020 at 02:38:46PM +0300, Peter Ujfalusi wrote:
>> Make sure that we call the dma_unmap_sg on the correct scatterlist on
>> completion with the correct sg_nents.
>>
>> We also should be calling dma_sync_sg_for_device() on the tx buffer be=
fore
>> giving it to the DMA and the dma_sync_sg_for_cpu() should be called on=
 the
>> scatterlist we received the data back.
>=20
> You might want to look into using struct sg_table and the DMA mapping
> helpers using it to simplify this a bit.

It would have simplified it a bit further if the dma_map_sgtable() would
have saved the dir we used when mapping (and then dma_unmap_sgtable()
would use the stored dir) and had a bool to tell that the mapping was
successful.

I'll send v2 with the use of sg_table in a bit after running some tests
to make sure it is working as expected. It is passing the extended boot
time tests on j721e.

- P=C3=A9ter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki