Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp281737pxk; Wed, 23 Sep 2020 03:07:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOT4dhvjmQituYHs4b40z+qpFg94ZV5guxJYt5Rmip6TRtBq6DW9QiNTmleW3dhmf5Zw8m X-Received: by 2002:a17:906:edca:: with SMTP id sb10mr9335574ejb.60.1600855651878; Wed, 23 Sep 2020 03:07:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600855651; cv=none; d=google.com; s=arc-20160816; b=c6n4r5tBgGJzrQCJd7kZCWRlKSRNaAlN3fZGNONSJYGjla4n35+LcfyG+zGgcjPRqF mT94Rmc7JHdr7I0wFbQog+0xZEX0ltuVhBaLCw69ehmBPJM/sdKBQn+2SzdXVkz9kYEO 5hWkei+OwxHDRHkDATfiKOf8I4LGtzslbq/ND6DpQLeb9KCWwutYfGl1idFkGRU6WYwk y6HPXOep3E56NvgXrbHyrjq3IMOLOEmOTcC3+wm3iUHrtXsdHRd8leO51Hmu2v48i6gH QVrlvRdWncYDrb8YeJ3vvpdXjX4gqjwV3NDaW5VlXmZPCRhpVAW/otRgTfuqRXlv2H6V LKqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=R+6pH9MDXo8iBZE23VD1Qz4m/pWUZJggcrrvmXTMzlM=; b=ba7/MFRwqBKw9iKUX9QrXxYGRaj8oOKbP/q2w4NdCib98T0etDDhpyg0mCDe2mLRX1 S4p5mOzFHmQz3IJHl5u4iMoqxZYJo/d1QJIWFRWHyvjTcpUveQw2O4anxjvssowhj2KL 3dSiM6IkV0CEf7qXw3K+fEbXQQOpAXOj8AqbBdH5IajitgYQLwLq3nXd21ABu5K0XiEB 8YCEVfWavd8bLm/IijkEC33yCaHngFvBZKfYlo1/wmOwFkWkDFvggPSnXP4aR8yVc37y B7K93kdh67Zlr27gR97YrJAAUGsDvqAM0g/UnYWfnoutwOvvn77nOqnQ+ajsy+G8RWII tusw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=ExALYf+e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si12460384ejx.142.2020.09.23.03.07.08; Wed, 23 Sep 2020 03:07:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=ExALYf+e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgIWKFv (ORCPT + 99 others); Wed, 23 Sep 2020 06:05:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgIWKFu (ORCPT ); Wed, 23 Sep 2020 06:05:50 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE48C0613CE; Wed, 23 Sep 2020 03:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=R+6pH9MDXo8iBZE23VD1Qz4m/pWUZJggcrrvmXTMzlM=; b=ExALYf+eJ59NgDjFaLDDQWGEv kB/1C35EtyKiUIkhcLpRwt2PDcrbvVbTxhs5IFERtgqltUk4aum3IZLfl3DHn6oOk9imExkrI/DfF mhzaVNsUaMpkkbLQhXKHTfbSg+y1REpp59J3d6P0iUGuK+hCHce1nXIJLzjTZYeRCszvJQrLToSs/ oNJZZEEsiAO8/Qqf+ddRW6OOUdIs6920AV7bpoyEPBvg5E6hV5Dp93UemFxEtQR7f1J/JJ2Wm7pWb MCUqyTvOeTNTsDJry0yRevPBt1739ZZIX6np7q6l66wqe3+7/ZHiM+bdessUmZturVDq2QUPP4Dpl 6rGa0uQ7A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37216) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL1eW-0003vf-NC; Wed, 23 Sep 2020 11:05:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kL1eQ-0003HJ-Ot; Wed, 23 Sep 2020 11:05:26 +0100 Date: Wed, 23 Sep 2020 11:05:26 +0100 From: Russell King - ARM Linux admin To: Christoph Hellwig Cc: Tony Lindgren , Janusz Krzysztofik , Aaro Koskinen , Robin Murphy , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/4] ARM/omap1: switch to use dma_direct_set_offset for lbus DMA offsets Message-ID: <20200923100526.GD1559@shell.armlinux.org.uk> References: <20200917173229.3311382-1-hch@lst.de> <20200917173229.3311382-2-hch@lst.de> <20200918054933.GK7101@atomide.com> <2184547.ElGaqSPkdT@z50> <20200921064418.GM7101@atomide.com> <20200921064723.GA18559@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921064723.GA18559@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 08:47:23AM +0200, Christoph Hellwig wrote: > On Mon, Sep 21, 2020 at 09:44:18AM +0300, Tony Lindgren wrote: > > * Janusz Krzysztofik [200919 22:29]: > > > Hi Tony, > > > > > > On Friday, September 18, 2020 7:49:33 A.M. CEST Tony Lindgren wrote: > > > > * Christoph Hellwig [200917 17:37]: > > > > > Switch the omap1510 platform ohci device to use dma_direct_set_offset > > > > > to set the DMA offset instead of using direct hooks into the DMA > > > > > mapping code and remove the now unused hooks. > > > > > > > > Looks nice to me :) I still can't test this probably for few more weeks > > > > though but hopefully Aaro or Janusz (Added to Cc) can test it. > > > > > > Works for me on Amstrad Delta (tested with a USB ethernet adapter). > > > > > > Tested-by: Janusz Krzysztofik > > > > Great, good to hear! And thanks for testing it. > > > > Christoph, feel free to queue this along with the other patches: > > > > Acked-by: Tony Lindgren > > > > Or let me know if you want me to pick it up. > > I'd prefer to pick it up through the dma-mapping tree, but preferably > I'd pick the whole series up once Russell has tested footwinder. I don't think that's going to happen very soon... seems way too much effort to pull down the appropriate tree to build and test. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!