Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200921195555.1050731-1-badhri@google.com> <20200921195555.1050731-5-badhri@google.com>
In-Reply-To: <20200921195555.1050731-5-badhri@google.com>
From:   Jun Li <lijun.kernel@gmail.com>
Date:   Wed, 23 Sep 2020 18:43:13 +0800
Message-ID: <CAKgpwJUqfyZv1+-A4R8R--O-u2R65T+VUxL6PtW4c6kG0FJWfg@mail.gmail.com>
Subject: Re: [PATCH v8 05/11] dt-bindings: connector: Add property to set
 initial current cap for FRS
To:     Badhri Jagan Sridharan <badhri@google.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Thierry Reding <treding@nvidia.com>,
        Prashant Malani <pmalani@chromium.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Linux USB List <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Badhri Jagan Sridharan <badhri@google.com> =E4=BA=8E2020=E5=B9=B49=E6=9C=88=
22=E6=97=A5=E5=91=A8=E4=BA=8C =E4=B8=8A=E5=8D=883:57=E5=86=99=E9=81=93=EF=
=BC=9A
>
> This change adds frs-typec-current which allows setting the initial curre=
nt
> capability of the new source when vSafe5V is applied during PD3.0
> sink Fast Role Swap.
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
> Changes since v1:
> - Changing patch version to v6 to fix version number confusion.
>
> Changes since v6:
> - Removed the redundant usb-connector.txt that I created by mistake.
> - Moved to yaml.
>
> Changes since v7:
> - Rebase
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml   |  8 ++++++++
>  include/dt-bindings/usb/pd.h                           | 10 ++++++++++
>  2 files changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.ya=
ml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 9bd52e63c935..1ca8e6a337e5 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -142,6 +142,14 @@ properties:
>      required:
>        - port@0
>
> +  frs-typec-current:
> +    description: Initial current capability of the new source when vSafe=
5V
> +      is applied during PD3.0 Fast Role Swap. "Table 6-14 Fixed Supply P=
DO - Sink"
> +      of "USB Power Delivery Specification Revision 3.0, Version 1.2" pr=
ovides the
> +      different power levels and "6.4.1.3.1.6 Fast Role Swap USB Type-C =
Current"
> +      provides a detailed description of the field.
> +    $ref: /schemas/types.yaml#/definitions/uint32

If it's a part of sink PDO, I think you don't need a new property for this,=
 just
define it directly into sink-pdos by adding a new PDO define for PD 3.0,
something like:

sink-pdos =3D <PDO_FIXED_v3(5000, 3000, PDO_FIXED_USB_COMM, FRS_CURRENT_1P5=
A)>;

Li Jun
> +
>  required:
>    - compatible
>
> diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
> index 985f2bbd4d24..db1ad4532197 100644
> --- a/include/dt-bindings/usb/pd.h
> +++ b/include/dt-bindings/usb/pd.h
> @@ -35,6 +35,16 @@
>
>  #define VSAFE5V 5000 /* mv units */
>
> +/*
> + * Based on "Table 6-14 Fixed Supply PDO - Sink" of "USB Power Delivery =
Specification Revision 3.0,
> + * Version 1.2"
> + * Initial current capability of the new source when vSafe5V is applied.
> + */
> +#define FRS_NOT_SUPPORTED      0
> +#define FRS_DEFAULT_POWER      1
> +#define FRS_5V_1P5A            2
> +#define FRS_5V_3A              3
> +
>  #define PDO_BATT_MAX_VOLT_SHIFT        20      /* 50mV units */
>  #define PDO_BATT_MIN_VOLT_SHIFT        10      /* 50mV units */
>  #define PDO_BATT_MAX_PWR_SHIFT 0       /* 250mW units */
> --
> 2.28.0.681.g6f77f65b4e-goog
>