Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 23 Sep 2020 13:39:14 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: fbcon scrollback broken was Re: Linux 5.9-rc6
Message-ID: <20200923113914.GA18149@duo.ucw.cz>
References: <CAHk-=wjSWKpiNbcMpzQ9fBUA5s11sU-STLztzQkHhCHtYvLP5A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT"
Content-Disposition: inline
In-Reply-To: <CAHk-=wjSWKpiNbcMpzQ9fBUA5s11sU-STLztzQkHhCHtYvLP5A@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--X1bOJ3K7DJ5YkBrT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> The one thing that does show up in the diffstat is the softscroll
> removal (both fbcon and vgacon), and there are people who want to save
> that, but we'll see if some maintainer steps up. I'm not willing to
> resurrect it in the broken form it was in, so I doubt that will happen
> in 5.9, but we'll see what happens.

Could you... like try not to make the job harder by merging miriad of
"let's kill the documentation" patches?

I needed the feature twice already this month, once during fsck, and
then five minutes ago, when oops scrolled by me during system
shutdown. Unfortunately, shift-pageup was not available to take a look
what is going on there.

Unfortunately, Greg backported your "fix" to all the stable releases,
so resulting damage will not be easy to repair.

For the record, making the security problem unexploitable should be as
simple as patch below.

Unfortunately, Linus' changelog does not exactly tell me what all the
known problems are. Willy Tarreau pointed me to
https://www.openwall.com/lists/oss-security/2020/09/15/2 , which has
some information, but all I can reproduce are transient screen
artefacts. If someone has more detailed information, that would be
helpful.

Best regards,
								Pavel

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 19cd4a4b1939..cb2d3e7eeac8 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -3211,6 +3212,9 @@ int tioclinux(struct tty_struct *tty, unsigned long a=
rg)
 			ret =3D fg_console;
 			break;
 		case TIOCL_SCROLLCONSOLE:
+			ret =3D -EPERM;
+			break;
+		 =20
 			if (get_user(lines, (s32 __user *)(p+4))) {
 				ret =3D -EFAULT;
 			} else {

--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--X1bOJ3K7DJ5YkBrT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX2sz4gAKCRAw5/Bqldv6
8o95AJ9Lf7Gsm80W0HzA9xnppbRKIaZH4ACgjZaGBXrzHpn3ExarPgEGnQVTRg0=
=IkHg
-----END PGP SIGNATURE-----

--X1bOJ3K7DJ5YkBrT--