Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200916105949.24858-1-fabrizio.castro.jz@renesas.com>
 <20200916105949.24858-3-fabrizio.castro.jz@renesas.com> <CAMuHMdU-DSqUmch3OR1pSbDkVNGDKx_YGT_432uYpoPDh_nS1Q@mail.gmail.com>
 <OSAPR01MB2740DB23267470CF995978E5C2380@OSAPR01MB2740.jpnprd01.prod.outlook.com>
In-Reply-To: <OSAPR01MB2740DB23267470CF995978E5C2380@OSAPR01MB2740.jpnprd01.prod.outlook.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 23 Sep 2020 15:33:26 +0200
Message-ID: <CAMuHMdXbhqYPrFDa4rY4xM_wQcVRCr3Lh=EQHbS+jAQvLADvhg@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert
 to json-schema
To:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Ramesh Shanmugasundaram <rashanmu@gmail.com>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Chris Paterson <Chris.Paterson2@renesas.com>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Fabrizio,

On Wed, Sep 23, 2020 at 1:55 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com> wrote:
> > > Convert the Renesas DRIF bindings to DT schema and update
> > > MAINTAINERS accordingly.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

> > > +if:
> > > +  required:
> > > +    - renesas,primary-bond
> > > +then:
> > > +  required:
> > > +    - pinctrl-0
> > > +    - pinctrl-names
> > > +    - port
> >
> > The last 3 properties must not be present for a secondary interface,
> > right?
>
> If you have both channels enabled, then one of the two has to define properties:
> * renesas,primary-bond, pinctrl-0, pinctrl-names, and port.
>
> If only one channel is enabled, then the primary bond concept loses its value,
> whether renesas,primary-bond is specified or not doesn’t matter anymore, but the
> enabled node has to specify the pinctrl related properties and the port.
>
> > To express that, I think you need to add:
> >
> >     else:
> >       properties:
> >         - pinctrl-0: false
> >         - pinctrl-names: false
> >         - port: false
>
> If I went with this, we would not be able to allow those properties to be specified in the
> only enabled node for single channels configurations.
>
> Is there a better way to approach this?
>
> I'll wait for this point to get sorted before sending v3 out.

The old binding said:

    -Required properties of an internal channel when:
    -       - It is the only enabled channel of the bond (or)
    -       - If it acts as primary among enabled bonds

    -- renesas,primary-bond: empty property indicating the channel
acts as primary
    -                       among the bonded channels.

so renesas,primary-bond is required for the only enabled node for
single channels configurations anyway?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds