Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp499188pxk; Wed, 23 Sep 2020 08:28:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx54JKfW4jTJdScAcv3xzsdzjG4QiS28hc6YJNAs+4a/isRtvQpnoqEiG6yB3xp0vnFOZj X-Received: by 2002:a05:6402:50f:: with SMTP id m15mr10739945edv.41.1600874882727; Wed, 23 Sep 2020 08:28:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600874882; cv=none; d=google.com; s=arc-20160816; b=FdzlmGxVUsLpwTBrlEmB8uiU1VqE+8gGgFkNJ+SNrDWuf2K/2l6jiReBJJZkvKJvYi tJkO0rpYLSSaLkyodxRyXPVU33dxLM48Pfx1qILlfyRPxy/+0cTqb3kMzp6r7+zlrwDv UpftUHQg+y26yx3LUZSDHLPMCxAMcwdOjfG4+rISFtiYcP2BGptqDh2uEF7AAQcCVo8b p9JaI9KDjNwwAdrtctWZUaDP31viuk38wHoS9tnmoc12ztwfFScNHE/LN14ElKPPHE2g 1tMEaF2RF+vjNBBb2mgzOSBT1nNUeK0nfWrkHMviDaXjC1OoPVrYrDJ1G7L0LZJSxO6j ki7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=Tbcdzb+UtWnZ3ZPTUheK81PKlyr1xEDFfH1mBCuMAnk=; b=LAYawVf71LghGoSr6FttgBYBTjWIS0ge/1VARxDe4AvlmzvQeaP1QAQtkCADXR/P9f uJMznw/e5OkQqcEjqoNVJhr4gJYaUNhZPff8k1zBxssKskHXh8i5CWI1b6+vZwR9V3c+ uKpO7uLiVOvfS6RUkkVsNy8aiTHNwZlbGQLASm+FoAhfGQbz4MxyFmasf30paqt5F1Va ish3A9GJ9Y2ecysJ0hm5hbgldBCK4i3hkaMC1pLGHv6Tco3hyn8LRZOkla94wfv1jyd8 o2r6YL9uWY0pnFKZTGYJ45lJtPIvkvBJqd29vy+lIO4qnrz1vRq1+XHD5yOkT5MyKU+K Bvdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si83853edi.411.2020.09.23.08.27.39; Wed, 23 Sep 2020 08:28:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbgIWPZN (ORCPT + 99 others); Wed, 23 Sep 2020 11:25:13 -0400 Received: from mga07.intel.com ([134.134.136.100]:58923 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgIWPZM (ORCPT ); Wed, 23 Sep 2020 11:25:12 -0400 IronPort-SDR: OTeINvi3nzndS+8v76fJOomgwfUiueNM1VmM1xJ6BrUWB8cGYXdym97hYNGmnCRc/umXCFToGo 15eWgXCoARxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="225055673" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="225055673" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 08:25:11 -0700 IronPort-SDR: YmR1SxFUzCMegOE29Z7WY8yRAbVnYEa0ijOOqMw2+EsFkZLLsa1UpifzHWDqWDrLKKEVl1TI3o RR2e/1UqSUyA== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="486478167" Received: from linortne-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.49.223]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 08:25:04 -0700 Date: Wed, 23 Sep 2020 18:25:02 +0300 From: Jarkko Sakkinen To: Sean Christopherson Cc: Borislav Petkov , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jethro Beekman , Jordan Hand , Nathaniel McCallum , Chunyang Hui , Seth Moore , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v38 16/24] x86/sgx: Add a page reclaimer Message-ID: <20200923152502.GI5160@linux.intel.com> References: <20200915112842.897265-1-jarkko.sakkinen@linux.intel.com> <20200915112842.897265-17-jarkko.sakkinen@linux.intel.com> <20200922104538.GE22660@zn.tnic> <20200922162437.GA30827@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200922162437.GA30827@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > if (IS_ERR(va_page)) <- needed a new VA page, allocation failed > return PTR_ERR(va_page); > else if (va_page) <- needed a new VA page, allocation succeeded > list_add(&va_page->list, &encl->va_pages); > else > <- reused the current VA page /* else the tail page of the VA page list had free slots. */ I added this comment as "the missing branch". /Jarkko