Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp499676pxk;
        Wed, 23 Sep 2020 08:28:43 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwlo/SoSSHOH0C0Z4IAeYHJSye+jJGgLp+1ueKibpJmWF6rShyS8spuLElEQIZCIssSfTRf
X-Received: by 2002:a17:906:692:: with SMTP id u18mr179109ejb.43.1600874923541;
        Wed, 23 Sep 2020 08:28:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600874923; cv=none;
        d=google.com; s=arc-20160816;
        b=BB4C2F/OkKprslirAPt26mNE7Znzih279Blfij7JnQhkNVUY9eaiiEKc+VGoeOL6Cv
         o9jKapu5PtKJbrFmcQ2ftuYAeKPCP8azrlrLymXWFnYaknPebTnaH5IJHeHRH53aGFat
         mR06e/QJQ5XlhxSm2deser2BjNfm7vi2UpLp9IXoWaGY/PZtmv2aD1H/UUiUf7jjKVC1
         5ol+qzb3gHntCMJi1y5CZps7FWa6wCYTk+bKu4+dyeAYQpuDjOhMDhAKM8FXMNDCwuIZ
         wMUZLFHPgqZGsq67d88l44HRbVnu1xXSwgx3iMRBQDF+eqIoFR3iYUq1WBv8lklvXivL
         fukQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=tEcppYbaHvOc+zDwI50BMA4krB7SREy/l5n2F8YUvpY=;
        b=ol7hj+pamXUr/ahgtAfmIrW9LxmdiDmusjHtqSnTMiP+CTzsYzgV5mVjORU6GOyM9r
         FPKFlo171YQZMwA012t84WxMx7H8nU3GdXahvOV5w5ZFptiVrP+NPJUDSesH7YDqFNMB
         OlCL15HqPhsC5MyTt7dB6H7BitIjCJxW4Q5otgrxkaWkS8+O4DzQsdFOjmo2I92Y/DcS
         5GfbsPIFYcaoT7b1ig4BALxzFej7eYaI7IylvMiuxCgIX+1uDnGBleUx1ZFdOHKbpPHU
         W6A1URGQcrKVXEv/tZIHG2tXDzpeWJBgUyXG/E802Xx7qx+FrRLBXKhHzmVqaWsd8OL0
         bt8g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=g7XBqqq+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id o2si85436eda.463.2020.09.23.08.28.19;
        Wed, 23 Sep 2020 08:28:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=g7XBqqq+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726672AbgIWP1V (ORCPT <rfc822;0330sisy@gmail.com> + 99 others);
        Wed, 23 Sep 2020 11:27:21 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42302 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726184AbgIWP1V (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Sep 2020 11:27:21 -0400
Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 297B0C0613CE
        for <linux-kernel@vger.kernel.org>; Wed, 23 Sep 2020 08:27:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=tEcppYbaHvOc+zDwI50BMA4krB7SREy/l5n2F8YUvpY=; b=g7XBqqq+dVb0S9s0KXfAjCs8db
        Fnrs8rRSLNhag0UXdsYC81acmH09tonukUGvUYVIg7iw4zWuuGd03kxHh64hdFwxNY8oVroSAY8LK
        rxWtv5S6SGNxbr4u0bZQ0uTeqs0B8IfuJQWinlV6drEJ5atKQyTERs1RsaceuuPPoBAIePht8aolT
        WAOqsKlMoHBs4NoTKausiBk2JuNdJ+1oueJBmQIl0pmu0ubYqGP/xqPPeY3AgfQ5ZpWEP2FSri61t
        ni6+PCoNE0riU4usfy+B1IO3g6lhAtHoMBBsQ6uMQBi9zBvgQP/dIQRyucvzNX6ZRyZAwQtzpWloz
        wIbQr3Hw==;
Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net)
        by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux))
        id 1kL6fc-0002Mi-32; Wed, 23 Sep 2020 15:27:00 +0000
Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (Client did not present a certificate)
        by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 852EE3003E5;
        Wed, 23 Sep 2020 17:26:58 +0200 (CEST)
Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000)
        id 6FDB6213DCC7B; Wed, 23 Sep 2020 17:26:58 +0200 (CEST)
Date:   Wed, 23 Sep 2020 17:26:58 +0200
From:   peterz@infradead.org
To:     Xianting Tian <tian.xianting@h3c.com>
Cc:     <mingo@redhat.com>, <juri.lelli@redhat.com>,
        <vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
        <rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: Use bool parameter for update_tg_load_avg()
Message-ID: <20200923152658.GX1362448@hirez.programming.kicks-ass.net>
References: <20200923132935.20778-1-tian.xianting@h3c.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200923132935.20778-1-tian.xianting@h3c.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 23, 2020 at 09:29:35PM +0800, Xianting Tian wrote:
> In the file fair.c, sometims update_tg_load_avg(cfs_rq, 0) is used,
> sometimes update_tg_load_avg(cfs_rq, false) is used. So change it
> to use bool parameter.

afaict it's never true (or my git-grep failed), so why not remove the
argument entirely?