Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp527495pxk; Wed, 23 Sep 2020 09:07:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywtq001jH4H9b5Hp7dijaj1KrgFtVqmtWhXQAVodz2dRMsocHBVUi2ZDRWKVbNSAgCLDNI X-Received: by 2002:a17:906:8687:: with SMTP id g7mr358327ejx.129.1600877259315; Wed, 23 Sep 2020 09:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600877259; cv=none; d=google.com; s=arc-20160816; b=NAfwa6yEAAIoGduLbHviACLpL7UMt0uEwFKFjVTagJzhYw5/oLon7OPGg+dJmbRnQn RTXCKFJH7Hnp8J1Xzognf/qKAvaxswO8rAZjXKOUi70KYglxz+BXmMaZtrZ+OJFpWl+A oYTJP7erAD/HcboRlfONZl9HttvmI8rGdjtdIUpsOfrdn5P1CQDB3wwGk/7lqp4la4ib S4iEMWoP4WfSEogk2nDFRYj/SfH90GPKMD5CI7jdZplcXUcd/pdUoqURmi1bkowm+G9p KvQBZaiKk4q8M5+KiJC7IK8enSJbVSca4Hj5y0DvTlVwVz43CfUjFydfKg1Z1ftV74YE 4bLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=bYY4v0xUKW+V9VzHQGgAzoUDOD/hbVajXOB7n6FQAF0=; b=ZzoOxJhMea7rqkCdtwcaj1haqLlceJuw6Rko4BwzkJ/6wIWl1DmZzThb+HZHrdqkDc BdqHiVuOF7lf4Rp0I9x6JkxavOT5wxyAHBQTJ5fLxmjF3wlgOB3o5pt1GBl00a1RX/WS N1wRm+K/liydoFKdFQSSQ/CGdi5BQcyCdN0/WU8HaIWKzkCTxq4PqwdtdG+qIISRYC5a 6SX6mWfLc7/52IEQD5xCVILlKvHdYQ+tINjOTIJLpwLhSJTDp27d4YWgOwEn+E3c0Wtb 0xWDKFsZJrQt9M9OJ9p2Emlw7NIHVDY43grCPjinCxMweSpu2znHhSrBJNQC8fQjwb1v 6JQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jiSXCwcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z1si182211edx.584.2020.09.23.09.07.15; Wed, 23 Sep 2020 09:07:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jiSXCwcC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbgIWQD3 (ORCPT + 99 others); Wed, 23 Sep 2020 12:03:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726681AbgIWQD3 (ORCPT ); Wed, 23 Sep 2020 12:03:29 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DFB6C0613CE for ; Wed, 23 Sep 2020 09:03:29 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id e17so589912wme.0 for ; Wed, 23 Sep 2020 09:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bYY4v0xUKW+V9VzHQGgAzoUDOD/hbVajXOB7n6FQAF0=; b=jiSXCwcC/9mz3F5aJuG19Xy21Yj23ok0rmXkRUdtSckcplQkLcHXm7ioPtobwvys2c /Phb0cg/ShfIOKKhYVjO/GhZHQUDBAHTgo5AggnE0heNoNE8JAdK0KtBtaEJkb538j0m vC2VE/HdKzP23D1eb9gngPxlC3s3RYgjxYbVm/WXtwdJmvlR5OOSnDUU8DVeCSjFilwA yZkzmbGBmz0Z1eshATp9Zp3hOI7Ci6frBzkrB1eUO8X9AbO0CLVTFws8xAWXhFL5Wrvn EpOHtOA9DNkh3hNOvdTR/WSu8vHGSBQ4jxEDTNgFH+MwtB7v9pQJrwY+8lqy0RjPdxVh jsgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bYY4v0xUKW+V9VzHQGgAzoUDOD/hbVajXOB7n6FQAF0=; b=U6NjMETeHlkBP/msV4aapVOuLYTK9ef89mKeuvOnW5QCpmKgerOv3Do0W3wupLZtph s+Wt5a3niA5nBQLX2xMWZ/VIqklT0AhgXEwvpPvZfcyVSd2nDmPWIK9ZML4PslAWqVTY qTgzCPTovUWkuqkyoMEzHngIcjlD9SVsqSdn6FBWeVdofX6bXeE0GzVAV0MFNXmSvS9m QGqWKkmMZJqScpgV6F7SO9TzsX0OH9tayLRxnjWIt58o5m695OzAIdIC04yjOuCeHiQ7 cjpAPaFzDIkbEZNaPHuiF7seOt/GBVi2FT2tO3zIsQkQLc7+rMYiM5zYgrLdqNID9BNb EGAQ== X-Gm-Message-State: AOAM532QNZI1OwFgUCN12cq56gGAL9FBBCYWElwOqq4wprwkMsn91CDm Odp1RAuGZU4k8+YoAte0mGS3t77Hszq2uQ== X-Received: by 2002:a05:600c:4108:: with SMTP id j8mr284278wmi.116.1600877007537; Wed, 23 Sep 2020 09:03:27 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id a11sm250764wmm.18.2020.09.23.09.03.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Sep 2020 09:03:26 -0700 (PDT) Subject: Re: [PATCH v2] nvmem: core: fix possibly memleak when use nvmem_cell_info_to_nvmem_cell() To: Vadym Kochan Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org References: <20200923135343.16565-1-vadym.kochan@plvision.eu> <7a072204-a4b8-e5ef-9ce2-4db176f70366@linaro.org> <20200923141334.GA16798@plvision.eu> <1f65dc6a-50f3-d4e5-f1ce-7a68fddde287@linaro.org> <20200923145107.GB16798@plvision.eu> <19c5fa23-41c9-f5c7-beaf-aeb9655bfefd@linaro.org> <20200923160226.GC16798@plvision.eu> From: Srinivas Kandagatla Message-ID: <60233595-b47b-8b1b-013b-51b4c0c7ef13@linaro.org> Date: Wed, 23 Sep 2020 17:03:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200923160226.GC16798@plvision.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/09/2020 17:02, Vadym Kochan wrote: > You mean do not do such func attributes breaking as I did (moved them > line upper) ? yes, for consistency reasons! --srini >