Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1600774764-50332-1-git-send-email-liheng40@huawei.com> <CAPY8ntCnsD=LfqxSG-HrkY1ZjUPSaXbGKC=nc4Xkc7a+a7jF3w@mail.gmail.com>
In-Reply-To: <CAPY8ntCnsD=LfqxSG-HrkY1ZjUPSaXbGKC=nc4Xkc7a+a7jF3w@mail.gmail.com>
From:   Eric Anholt <eric@anholt.net>
Date:   Wed, 23 Sep 2020 10:27:29 -0700
Message-ID: <CADaigPWBgjRPq54_swpEmvHxPB0mY-FdzJpbeWO+1O23BV_zwg@mail.gmail.com>
Subject: Re: [PATCH -next] drm/v3d: Remove set but not used variable
To:     Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc:     Li Heng <liheng40@huawei.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        LKML <linux-kernel@vger.kernel.org>,
        DRI Development <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Sep 23, 2020 at 6:13 AM Dave Stevenson
<dave.stevenson@raspberrypi.com> wrote:
>
> Hi
>
> On Wed, 23 Sep 2020 at 08:53, Li Heng <liheng40@huawei.com> wrote:
> >
> > This addresses the following gcc warning with "make W=3D1":
> >
> > drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning:
> > =E2=80=98v3d_v3d_pm_ops=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Li Heng <liheng40@huawei.com>
> > ---
> >  drivers/gpu/drm/v3d/v3d_drv.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_dr=
v.c
> > index 9f7c261..05140db 100644
> > --- a/drivers/gpu/drm/v3d/v3d_drv.c
> > +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> > @@ -70,10 +70,6 @@ static int v3d_runtime_resume(struct device *dev)
> >  }
> >  #endif
> >
> > -static const struct dev_pm_ops v3d_v3d_pm_ops =3D {
> > -       SET_RUNTIME_PM_OPS(v3d_runtime_suspend, v3d_runtime_resume, NUL=
L)
> > -};
> > -
>
> This looks to be the wrong approach, and I think a patch has got
> dropped somewhere.
>
> On our Raspberry Pi downstream vendor tree we have a patch [1] from
> Eric that renames v3d_v3d_pm_ops to v3d_pm_ops (don't need the
> duplicated suffix), and adds it to v3d_platform_driver. Why that never
> made it through the mainline trees I don't know.
>
> Eric: How good's your memory on this one?

The RPM stuff ended up abandoned because I didn't have any support in
debugging the power domain driver and I punted for a downstream hack.
We should at least be using these ops, though.