Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp628976pxk; Wed, 23 Sep 2020 11:43:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx18h4yPZdgQfy9PUicmIKVRPMLIokQLwWjP1bd7Yka3lLOfK84+cxLIuWV1hd4fAIoqN+I X-Received: by 2002:a17:906:e4f:: with SMTP id q15mr1026397eji.155.1600886590629; Wed, 23 Sep 2020 11:43:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600886590; cv=none; d=google.com; s=arc-20160816; b=QRpPlZDukHtijxCYQ4lktIjXNeFgmwwqb7bYt0SLKVrYgfRMG05/P52l+EJdQyFGz8 OYQ2c05ivb+UNPMELpH5R1UCAtEduS52HN0Lj3LlpMUanIlhOtBPCb3bHgODO/dUHJss dzHeOFeGZCumTnxLHBjiQjL+t8Gh70UXuibQlQ9UF9ldNsX6nzhS87zz9juuCtdyilRB 2mLix1U0OYmQGoPAJkB/zKyTjUGNrV3Cmxrp/da/tGh28iDChd4gnEBtuq0AxHEiE7D+ RsfNB86M6NIqRcYciMtlrKAzxKi/3bB73MAA2FGUQ1IR01SNdgf1PWdETqfAszxMolp/ ebcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=iMjlhbOGV5L2ljtLni91GYUVVvFV7DW0WaNEN/WZeiQ=; b=aZdFK9xQDoPCx8ONHX+jv5haARGxsRqv5HJLOf4R8JqoD/dUvHuTQAg81WXxLIhbtC Hr/PBwg0FG4wS8FurS2a4smBZs3WuFh7+FPHds2KZm0ehkYXwwTHDUFor2dRw9VEdgxJ eY1FIFhJH9k0+KZ6UAyyMAlkWSr+Uw+Kv3/h11sSOz2NbausnG0gTkRtAW29wVvq+ZaQ Bc1wTR2uCoxPTt3O/SBnWVPUpdMcVdPmGuQ3jls3SqNNlOzh7sPJxnKvP8O7okp+0IsC 5V2y2ESps4LZX7ZsO2j3kS0f7Fod8QR0q5bUNdFfDvIxWZdHTvSX2Z9Pq4r+2lp9MJOe aVlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=LHWMb6zL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si512631edl.504.2020.09.23.11.42.46; Wed, 23 Sep 2020 11:43:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=LHWMb6zL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbgIWSls (ORCPT + 99 others); Wed, 23 Sep 2020 14:41:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbgIWSlr (ORCPT ); Wed, 23 Sep 2020 14:41:47 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A522AC0613CE; Wed, 23 Sep 2020 11:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=iMjlhbOGV5L2ljtLni91GYUVVvFV7DW0WaNEN/WZeiQ=; b=LHWMb6zLD8EZxE3V1b7jJdUa40 /HG/CGunxCc24zT9ngmZsgMUYfTOeYRWCHcN89bN6RmcVigzNUp7l28P3ji1CYUP/Eaa0auk/jBDO 1/qWkKZMq9Lxy1G8Gz4aKoLxwVDxIp36h7SxVj/rrqm1mD1TalUPnrEAh1LMLbqRydKkplXA7cjym Zr3rxS9UQei517W6eRx6CUoebRRzBgM+uKORR0izJ4WyGnfnIRBMagemUBA1ggLJyPjKwNJstKf3n fmIgoGnFdAhS8JpHrS59HBtdbM+WSqskBqtFNQIXUoETtYiGj8ydXXBzvktQ3lUKkkEb0WJ8A4M9N wjvLZUrA==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL9hx-0003jd-87; Wed, 23 Sep 2020 18:41:37 +0000 Subject: Re: [PATCH v4] Introduce support for Systems Management Driver over WMI for Dell Systems To: "Limonciello, Mario" , Divya Bharathi , "dvhart@infradead.org" Cc: LKML , "platform-driver-x86@vger.kernel.org" , "Bharathi, Divya" , Hans de Goede , Andy Shevchenko , mark gross , "Ksr, Prasanth" References: <20200923113015.110980-1-divya.bharathi@dell.com> <9b015765-de6f-3b2a-8804-e23864eb8806@infradead.org> From: Randy Dunlap Message-ID: <23df654d-e7ce-dcc8-df81-1d4cdb62f001@infradead.org> Date: Wed, 23 Sep 2020 11:41:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/23/20 11:39 AM, Limonciello, Mario wrote: >> -----Original Message----- >> From: Randy Dunlap >> Sent: Wednesday, September 23, 2020 12:12 >> To: Divya Bharathi; dvhart@infradead.org >> Cc: LKML; platform-driver-x86@vger.kernel.org; Bharathi, Divya; Hans de Goede; >> Andy Shevchenko; mark gross; Limonciello, Mario; Ksr, Prasanth >> Subject: Re: [PATCH v4] Introduce support for Systems Management Driver over >> WMI for Dell Systems >> >> >> [EXTERNAL EMAIL] >> >> Hi, >> >> On 9/23/20 4:30 AM, Divya Bharathi wrote: >>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >>> index 40219bba6801..4fd7a3f0a904 100644 >>> --- a/drivers/platform/x86/Kconfig >>> +++ b/drivers/platform/x86/Kconfig >>> @@ -430,6 +430,18 @@ config DELL_WMI >>> To compile this driver as a module, choose M here: the module will >>> be called dell-wmi. >>> >>> +config DELL_WMI_SYSMAN >>> + tristate "Dell WMI Systems management WMI driver" >> >> Could you drop one of those "WMI" strings or are both of them needed? >> > > Thanks, that's a good suggestion. How about instead: > > "Dell WMI based Systems management driver" WMI-based OK. Thanks. -- ~Randy