Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 23 Sep 2020 21:30:05 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Michael Auchter <michael.auchter@ni.com>
Cc:     j.lamorie@rocketlab.co.nz, Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Rob Herring <robh+dt@kernel.org>,
        Rob Herring <robh@kernel.org>, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: ad7291: add binding
Message-ID: <20200923213005.1e52efc9@archlinux>
In-Reply-To: <20200922144422.542669-2-michael.auchter@ni.com>
References: <20200922144422.542669-1-michael.auchter@ni.com>
        <20200922144422.542669-2-michael.auchter@ni.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 22 Sep 2020 09:44:21 -0500
Michael Auchter <michael.auchter@ni.com> wrote:

> Add device-tree binding for ADI AD7291 ADC.
> 
> Signed-off-by: Michael Auchter <michael.auchter@ni.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Hi Michael,

I tweaked this a bit whilst applying as below.

Hope that's fine with you. Let me know if not.

Applied series to the togreg branch of iio.git and pushed out as testing.
I'm not sure if this will make 5.10 or not as we are rather tight
for a final IIO pull request.

Thanks,

Jonathan

> ---
>  .../bindings/iio/adc/adi,ad7291.yaml          | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml
> new file mode 100644
> index 000000000000..93aa29413049
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7291.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7291.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AD7291 8-Channel, I2C, 12-Bit SAR ADC with Temperature Sensor
> +
> +maintainers:
> +  - Michael Auchter <michael.auchter@ni.com>
> +
> +description: |
> +  Analog Devices AD7291 8-Channel I2C 12-Bit SAR ADC with Temperature Sensor
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ad7291.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,ad7291
> +
> +  reg:
> +    maxItems: 1
> +
> +  vref-supply:
> +    description: |
> +      The regulator supply for ADC reference voltage.
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 0

These two don't need to be here.

> +
> +required:
> +  - compatible
> +  - reg

additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ad7291: adc@0 {
> +        compatible = "adi,ad7291";
> +        reg = <0>;
> +        vref-supply = <&adc_vref>;
> +      };
> +    };
> +
... added and empty blank line removed.