Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 5/9] surface_aggregator: Add error injection
 capabilities
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        =?UTF-8?Q?Bla=c5=be_Hrastnik?= <blaz@mxxn.io>,
        Dorian Stoll <dorian.stoll@tmsp.io>
References: <20200923151511.3842150-1-luzmaximilian@gmail.com>
 <20200923151511.3842150-6-luzmaximilian@gmail.com>
 <20200923174543.GA102853@kroah.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <11657eb7-88a8-0c24-f7ee-fef9679c7837@gmail.com>
Date:   Wed, 23 Sep 2020 23:28:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200923174543.GA102853@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/23/20 7:45 PM, Greg Kroah-Hartman wrote:
> On Wed, Sep 23, 2020 at 05:15:07PM +0200, Maximilian Luz wrote:
>> This commit adds error injection hooks to the Surface Serial Hub
>> communication protocol implementation, to:
>>
>>   - simulate simple serial transmission errors,
>>
>>   - drop packets, requests, and responses, simulating communication
>>     failures and potentially trigger retransmission timeouts, as well as
>>
>>   - inject invalid data into submitted and received packets.
>>
>> Together with the trace points introduced in the previous commit, these
>> facilities are intended to aid in testing, validation, and debugging of
>> the Surface Aggregator communication layer.
>>
>> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> 
> Ok, this is ridiculous.
> 
> You are dropping a whole new subsystem on us, with full documentation,
> correct driver model integration, crazy debugfs interactions (I made fun
> of the patch, but the code did work, you just did more work than was
> needed), proper auto-loading of modules, tracing, documentation for more
> things than is ever expected, and now you are adding error injection
> support?
> 
> You just made all other code submissions of new subsystems I have gotten
> in the past 2 months look like total crud.  Which, to be fair, they
> probably were, but wow, you just stepped up the level of professionalism
> to a whole new height.
> 
> I can only dream that "real Linux companies" take note and try to follow
> this example.  I think I will point them all at this in the future and
> say, "go do it like this one."
> 
> very very very nice work, we owe you the beverage of your choice.
> 
> greg k-h


Wow, thank you very much for those kind words! That means quite a lot to
me.

To be fair, I've been working on this whole project for about two years
now and a large part of the code has been rewritten in the last half a
year, specifically to get it ready for the kernel. So I guess that might
relativize things a bit :)

Thanks again,
Max