Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp728845pxk; Wed, 23 Sep 2020 14:42:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/qKk1MaI66dRToHn1aXTZmsw/hgl8aXl1mK/e/LqE7vPHAB+76YM+BP+KRz7CoFwdf+sT X-Received: by 2002:a17:906:d97b:: with SMTP id rp27mr1711016ejb.18.1600897363832; Wed, 23 Sep 2020 14:42:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600897363; cv=none; d=google.com; s=arc-20160816; b=VkCmNXT40FmnJwNfmOSFfM+YDSE1m7DXvT4FrshC3DvYSkpeM4nMGQT7PVg7SRhZgy ZHttNmlkgNMu39kTqzbu/aEg587hfyPRoHx+ae5xXsfZo+7dE+LKRVmuHoTOi7si/Jzp HNpGP4m/P17tU7p6qqs+rD1Mb22CXNXTbhkLadfcxXWUHixDNTCP5tSZv0uJL1XIYD9j Mp7bXmZyKOSBk7sXG2ye+z+JfFIf0+WFAMghzp7YiIrNRU86SdcpTMoQwNgPuTCYUO6A ENHy41bliTvdyVSr8XVWiQBH+x2hV8inAh466eb3qTEkX8nD6Aa/nZaFkUpMVru9fhLN XM0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=1Wh3x2CtDoFB2eqD6SH4S1e6dq6OTRl/r6G/BQ8ykYo=; b=J1ATGMZtkfBxpg4RAFwlMExBMFcWbW36Y3t7kDlx+LKS8LBsEcSoH0GPgfxQJwphf9 Oht+KIbFOx6Ou0KxrNkr4o8u1M0jFWj9HyzwYhDBaXWHp9Vf4x2ChPbjsFxA0F8Hcjbj 4YlYtqdzGNobDgDYS9xwNhOiXgtyJMxOSH896JEAbqm+6l9c/eOP3ofloMzGJQxqV92e jpa9rLMWzZfHCSBNbf2rayUteGLRFMFKzrYs3FqDLhBuM7J+7uGiyQwVi5JKJBFhwLDe K010XWjKnUXhlVWqJ/eYBCAmdy8KPV+85WrUGLsK3dyclCyGRhcK6jQtuj32hUDhuv4+ eI4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bKrC3FE1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q6si707480ejx.221.2020.09.23.14.42.20; Wed, 23 Sep 2020 14:42:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bKrC3FE1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbgIWVjV (ORCPT + 99 others); Wed, 23 Sep 2020 17:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726134AbgIWVjV (ORCPT ); Wed, 23 Sep 2020 17:39:21 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE3F2C0613CE; Wed, 23 Sep 2020 14:39:20 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id w7so482497pfi.4; Wed, 23 Sep 2020 14:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1Wh3x2CtDoFB2eqD6SH4S1e6dq6OTRl/r6G/BQ8ykYo=; b=bKrC3FE1jJWWmcwm9I39qxkDOAL9pS8Xtyjj5d+m4TxLaxLwjiFjEJdsKenfnpWjwz 4+uIKutFqq605sGWccUXuQFUGJe9DKdpY3D/if3wL7TVT6JyLiLprYMWoKVn2mMkm+oO Xu9iJNhGMJ8GfuAYEwNURrqVOii/HUXu8YwC34IK9OhlGIxir5TBcRFqVfNuzDDgDBeB 4V0XjtwBwiL1HkwybKEMMp0jWubzRsTH2yq4EpkEWovx4j0pm0nHX3YxWl6H94JcSN3c DJk4AG5IG5aC+wlk3n6JRMCG60UEBjTajux7k58oOdS7k+Oh3oVFvvCBzo33bSnK3VSv 4LQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1Wh3x2CtDoFB2eqD6SH4S1e6dq6OTRl/r6G/BQ8ykYo=; b=j5uiEdwsv/rD/koYxLVNpZPQSeN4GZHHqwE5LLYutz44xBAM8978EOqSV+xaz9HZ0T xlwg+TIe5dbn1x5VakGteDqJlv+QlzD3tcpUV4wV8GU/XnnhTLL0dSFaNlk7DT94ZrgO BPCG3eLOgmiKnDTZQnizRnVhH1Ctq8x4peT7j2aC5KKMunLoHB95KpC+50S/wRtmXtHH G7F1kg5I/yuLtPlRxSCMjTot8J7aShRWYWK8jzGv2mhl+QrMJXMYyEdjk72UCxmLDeJi jbuv4aHAJVA3PPuLcIA8oC4K+zezF2MAVqjPm57DsKgRGrWUjbTDr0tnvil3NKMBP0th 1NVQ== X-Gm-Message-State: AOAM532j8pPl2LGl4SaNbyyImN7odBJMZZc7yY2PXMQQQia7cPQjtDSS G58T+M30DjEKzle/MeMA08E= X-Received: by 2002:a63:f807:: with SMTP id n7mr1403150pgh.311.1600897160140; Wed, 23 Sep 2020 14:39:20 -0700 (PDT) Received: from [10.67.49.188] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id z22sm5562584pjq.2.2020.09.23.14.39.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2020 14:39:19 -0700 (PDT) Subject: Re: [PATCH net-next v2 0/2] net: dsa: b53: Configure VLANs while not filtering To: Vladimir Oltean Cc: "netdev@vger.kernel.org" , "David S. Miller" , Jakub Kicinski , Andrew Lunn , Vivien Didelot , open list , "olteanv@gmail.com" , "nikolay@nvidia.com" References: <20200923204514.3663635-1-f.fainelli@gmail.com> <20200923205148.guukg3k7wanuua3c@skbuf> <20200923213055.t7hqzuar2nivatzz@skbuf> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <1e7bffdf-cb4d-5a31-aef7-4595ba3a8b64@gmail.com> Date: Wed, 23 Sep 2020 14:39:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200923213055.t7hqzuar2nivatzz@skbuf> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/23/20 2:30 PM, Vladimir Oltean wrote: > On Wed, Sep 23, 2020 at 11:51:48PM +0300, Vladimir Oltean wrote: >> On Wed, Sep 23, 2020 at 01:49:54PM -0700, Florian Fainelli wrote: >>> On 9/23/20 1:45 PM, Florian Fainelli wrote: >>> >>> David, Jakub, there is an unnecessary header inclusion in >>> net/dsa/tag_brcm.c in the second patch and the description at the end of >>> the commit was not updated, let me send a v3 right away. >>> -- >>> Florian >> >> Wait a few minutes, I don't think anybody has had a chance to look at it.. > > So I studied a little bit the situation with the MAC header pointer in > the second patch, especially since there are 2 call paths, but it's ok, > since at that point the skb->data points to its final position already, > then the MAC header is naturally 14 bytes behind. > I've been testing with the ocelot driver which resets the MAC header > manually, that explains why I missed that. Anyway, if there are no other > comments I think you can resend. Yes, I was looking at tag_ocelot.c as well for a reference. At some point I was considering adding a version that let the tagging driver specifying the struct vlan_ethhdr reference directly since the tagging driver knows, but using skb_set_mac_header() works equally well in a more portable way even. Thanks, v3 on its way with your A-b tag. -- Florian