Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp807823pxk; Wed, 23 Sep 2020 17:25:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw86lBLj33hbSw0h+Ar0Zfq2V3HFrrXAygGNQGkyCHg1b+2RvZ7rTIuR9TkeYAjwglaPxu2 X-Received: by 2002:aa7:d417:: with SMTP id z23mr1925012edq.62.1600907114179; Wed, 23 Sep 2020 17:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600907114; cv=none; d=google.com; s=arc-20160816; b=FOHg83hs7OQi5o/jHqxNRflZ8yqXLSsdQwR5v7Q5+8+N1EzBji/DITT/O/fMpZ0qx5 uxpIWPOw9eIz7LhaTlvWSKrvi57ZIl+QT8HNDHM1J2LZRZ3ALO81ZaAhOPsdwYu6A4KU p0Q8kjPDbX7zZNfkfhkstQLQJOHUxGR8AiW01e0zjO/kbqrZAejBaJR8OT4G3dPZuEMK WrQ3XJPVtuZRp8SjpvGdysLtCCelKQl18Ow+DUmcUbqNzkl2tN0dv1A1X7PXWWCgQVIZ HYPl8eYF/xv3NppydwhCEHB9DFzrltMPRVMhSxl+05LzQSpY+8qc/9op7fNkjdGUGonu K78A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Ppa93uouQWgn/xma2hgyayty8792jozcpCmzS1B9xb0=; b=uQnaqokLwlJyCsy+vSXxVdXFb8K5tYcBXy7f2nNZj3vGOcMJGhTyVdlbb6aN5LBqps AbrrtuuSnp/gWQdYFDt+GeIStTqtT+lJ+gv8p+0ESGi4DAIEbj3rW7I435qAvSIU0GAn B0iWZMr0wchTthxXCyvmzGrj5bDygAGCIlLsiXbNRCx3v+U0JFg5G+yzXz/0J9G2t6Hl EQaajT6WCQ/za1kfvMlwGz7mOGBTTN6Vcu6D/ARAqM/c1Ynmfa08UYCjAMkIHCVzzIjq +vsQ35MJCsRI4tTRJUCKC6mCI0A4mRteoiBo1bVWHjR1lhBScPEPi6vJ5l4VqLldTstO Sf0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yd22si1308549ejb.546.2020.09.23.17.24.51; Wed, 23 Sep 2020 17:25:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726714AbgIXAXw (ORCPT + 99 others); Wed, 23 Sep 2020 20:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbgIXAXv (ORCPT ); Wed, 23 Sep 2020 20:23:51 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4F59C0613CE; Wed, 23 Sep 2020 17:23:51 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7C51C11E442B7; Wed, 23 Sep 2020 17:07:03 -0700 (PDT) Date: Wed, 23 Sep 2020 17:23:49 -0700 (PDT) Message-Id: <20200923.172349.872678515629678579.davem@davemloft.net> To: saeed@kernel.org Cc: hkallweit1@gmail.com, geert+renesas@glider.be, f.fainelli@gmail.com, andrew@lunn.ch, kuba@kernel.org, gaku.inami.xh@renesas.com, yoshihiro.shimoda.uh@renesas.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev" From: David Miller In-Reply-To: <20200923.172125.1341776337290371000.davem@davemloft.net> References: <20200923.172125.1341776337290371000.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 23 Sep 2020 17:07:03 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller Date: Wed, 23 Sep 2020 17:21:25 -0700 (PDT) > If an async code path tests 'present', gets true, and then the RTNL > holding synchronous code path puts the device into D3hot immediately > afterwards, the async code path will still continue and access the > chips registers and fault. Wait, is the sequence: ->ndo_stop() mark device not present and put into D3hot triggers linkwatch event ... ->ndo_get_stats64() ??? Then yeah we might have to clear IFF_UP at the beginning of taking a netdev down.