Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Leo Li <leoyang.li@nxp.com>
To:     Michael Walle <michael@walle.cc>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
CC:     Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: RE: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
Thread-Topic: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
Thread-Index: AQHWkY/3EoU1wnrBSEO6n1vlKlAjpql28PzQ
Date:   Thu, 24 Sep 2020 00:35:17 +0000
Message-ID: <VE1PR04MB6687AC23E100D138FEDB012A8F390@VE1PR04MB6687.eurprd04.prod.outlook.com>
References: <20200923095711.11355-1-michael@walle.cc>
 <20200923095711.11355-2-michael@walle.cc>
In-Reply-To: <20200923095711.11355-2-michael@walle.cc>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f4e205d5-aef5-43bc-33d0-08d86021b6ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2020 00:35:18.0105
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XjMRSILYLvNVIAVm00phrl4aJZSdd7npI6cYfc7P1742ROlOKV0Eg0muUpB8aXmgELIvAyzDsgrI2k4JrSwbOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4061
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Wednesday, September 23, 2020 4:57 AM
> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; lin=
ux-
> kernel@vger.kernel.org; linux-can@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> Herring <robh+dt@kernel.org>; Marc Kleine-Budde <mkl@pengutronix.de>;
> Joakim Zhang <qiangqing.zhang@nxp.com>; Michael Walle
> <michael@walle.cc>
> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
>=20
> The LS1028A has two FlexCAN controller. These are compatible with the one=
s
> from the LX2160A. Add the nodes.
>=20
> The first controller was tested on the Kontron sl28 board.
>=20
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 0efeb8fa773e..807ee921ec12 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -386,6 +386,24 @@
>  			status =3D "disabled";
>  		};
>=20
> +		can0: can@2180000 {
> +			compatible =3D "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-
> flexcan";

The explicit compatible strings cannot be found in the binding, but matched=
 by the "fsl,<processor>-flexcan" pattern in the binding.  Is this consider=
ed to be acceptable now?

> +			reg =3D <0x0 0x2180000 0x0 0x10000>;
> +			interrupts =3D <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks =3D <&sysclk>, <&clockgen 4 1>;
> +			clock-names =3D "ipg", "per";
> +			status =3D "disabled";
> +		};
> +
> +		can1: can@2190000 {
> +			compatible =3D "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-
> flexcan";
> +			reg =3D <0x0 0x2190000 0x0 0x10000>;
> +			interrupts =3D <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks =3D <&sysclk>, <&clockgen 4 1>;
> +			clock-names =3D "ipg", "per";
> +			status =3D "disabled";
> +		};
> +
>  		duart0: serial@21c0500 {
>  			compatible =3D "fsl,ns16550", "ns16550a";
>  			reg =3D <0x00 0x21c0500 0x0 0x100>;
> --
> 2.20.1