Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp829127pxk; Wed, 23 Sep 2020 18:10:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoiZHjx+guYEvvxTpwlgz3K/SMqLu23LnsIHkXJZMWQxDxOKrEDMmq5OvRcfIVpeTsmEHq X-Received: by 2002:a17:906:5812:: with SMTP id m18mr2357526ejq.204.1600909842589; Wed, 23 Sep 2020 18:10:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600909842; cv=none; d=google.com; s=arc-20160816; b=lEi5Cr7Q0ugUeKf4vucBTLIZsn7T6o++zWVoJeqweLFpIbXrw0r6BUk5KRQpgbLSxt WN7LNT6rpsldjg/QyEGZlw0X3CTX31LXjWrUOZ7SN/MmG/VnsoxaBSZbQgyY17l5QZYh HRSQWEDRHLZ4ouCvODjaTR11rmaBWusCnp1DXeQ/ca9G7UXICOsTbu4RxhaS7U0/ZYZL zFPeK0NTNzgCl9+S4y0j6ZzNakyWFPa9+QlQyQEJDzGEXfWEddRSRCfBshpKC8gnpiPL b2hp/2kJ7BsyGVPBjMOy9iOnB6BkTFiNxpMeKiOAWu7E12Y+FTVeKmHVkSVYOH7wzGeW kV0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=/cMQYXVjPr0yIfqBDmqQYY+IPDCLyD/BGKH1zDa0kyA=; b=RsQ8Q+KxyDmz/tlZV4apKZCgPXD2WlndccWtPrcoYhQsnNWVl/ZXgvBjTu07JpPi/s te4Js5eZH695Eel+wNTG1bJSYvLuQ6thQxUI4xyOKDzjdqlecEWgoEfe+Hdj1c/8BuH4 AsSLCN1sg5g5EWO+YrMvDdTPEqQqvTK0ogCcszI0MElvW1aWVlYmiSjdloVt9fUYIUcK aehCRJhF+A77Njhntiv0SOcSS9MTZH2wW15UXe51/5bgPvqIgQ+D7Ia+ro9OYkIYfndm C3cJbXyU/CWIe8ggZcks43f87k1mVzqbqquGXN2/10Jbk8HORfI+1LKQrR0gwiC0qi79 VXiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ci12si1080611ejc.448.2020.09.23.18.10.19; Wed, 23 Sep 2020 18:10:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbgIXBJK (ORCPT + 99 others); Wed, 23 Sep 2020 21:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbgIXBJJ (ORCPT ); Wed, 23 Sep 2020 21:09:09 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F9A0C0613CE; Wed, 23 Sep 2020 18:09:09 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4A1F3127111A2; Wed, 23 Sep 2020 17:52:21 -0700 (PDT) Date: Wed, 23 Sep 2020 18:09:07 -0700 (PDT) Message-Id: <20200923.180907.1867807213397459967.davem@davemloft.net> To: weifeng.voon@intel.com Cc: mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joabreu@synopsys.com, peppe.cavallaro@st.com, andrew@lunn.ch, alexandre.torgue@st.com, boon.leong.ong@intel.com, chen.yong.seow@intel.com, mgross@linux.intel.com Subject: Re: [PATCH v1 net] net: stmmac: removed enabling eee in EEE set callback From: David Miller In-Reply-To: <20200923085614.8147-1-weifeng.voon@intel.com> References: <20200923085614.8147-1-weifeng.voon@intel.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 23 Sep 2020 17:52:21 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Voon Weifeng Date: Wed, 23 Sep 2020 16:56:14 +0800 > EEE should be only be enabled during stmmac_mac_link_up() when the > link are up and being set up properly. set_eee should only do settings > configuration and disabling the eee. > > Without this fix, turning on EEE using ethtool will return > "Operation not supported". This is due to the driver is in a dead loop > waiting for eee to be advertised in the for eee to be activated but the > driver will only configure the EEE advertisement after the eee is > activated. > > Ethtool should only return "Operation not supported" if there is no EEE > capbility in the MAC controller. > > Fixes: 8a7493e58ad6 ("net: stmmac: Fix a race in EEE enable callback") > > Signed-off-by: Voon Weifeng Please do not insert empty lines between Fixes: and other tags. All tags are equal and belong together in a group. I fixed that up, applied the patch, and queued it up for -stable. Thank you.