Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp830105pxk; Wed, 23 Sep 2020 18:12:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJ5AYHFvU24GpeZ+a5mHtdpHXxRvbsRYen3ryT6Xczuiju8wqUxl+GiFpIUvdcqLU6VHMD X-Received: by 2002:a17:906:2dc1:: with SMTP id h1mr2241818eji.436.1600909960298; Wed, 23 Sep 2020 18:12:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600909960; cv=none; d=google.com; s=arc-20160816; b=gqEyhgSBhjAexBhGZ3/ePbZO3oxQI5MYVGgaGOXFp/3OjM4IlAiOHmqkizcerw6BwU Hp9Z3ar1i6+KngpdueF9WsH2jlfKw/+I+aqqJxr7OfFqP17z8ZwXO2l2N1ZjGwyG1eIR jC7g31NiXvHZd9nfe/kYRQqG0+TOnMSrY4eIwSe6CWZUQrkowjq/lM2p07bln+qGtoF9 hH26f10ARVbaQ13MYgeO7rM07pO4ebAOCSrZ7NZ/lvAlp2dwGV6hweIeL+624VD1Uv4B PlxvvxEojO352VHcmeLwFuSZFKkfW1XRVwiAMKiWxxbSu8IlkUh2Ew2pD743etKEo6zs BpwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=qQQuLYDfeVFeHIVo6KlthAiL+jrmZKrhWY1UyWpzaxQ=; b=m1cIIttlAOo5WBCnJrkSwW8JkNh3G1icdgx6f/+z7YCBJPiihNbEtPNRj5Hv8rVtl7 Ak4AObgyF7uG5jkb+PLOx3KVIUFf9z+yYFMxsMjGqseq/jnAS9jUBasFGASBbAXgYmZq AlutEfKpoUCdcSRK7XSrZh9ntM95nA3KVqIN3xybbs0J4zMsdI9ziDceZ8+ogrk4ukJV wtyy778mrFiJ67MgYzAIYqn9y68+IlYzQ3sQaHaceVJZnnCj2xqBSoV5lKFeXIpQlXux D6US8e4MULy0LtvokA2OmYTsQo1L2sqQzAUIbnJV42NjVlJ3RJsuOjmC9hiDacK3S6oT 1b2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si1068734eds.432.2020.09.23.18.12.16; Wed, 23 Sep 2020 18:12:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726864AbgIXBKd (ORCPT + 99 others); Wed, 23 Sep 2020 21:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726599AbgIXBKd (ORCPT ); Wed, 23 Sep 2020 21:10:33 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1683C0613CE; Wed, 23 Sep 2020 18:10:33 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1B48312711881; Wed, 23 Sep 2020 17:53:45 -0700 (PDT) Date: Wed, 23 Sep 2020 18:10:31 -0700 (PDT) Message-Id: <20200923.181031.1814913923203712388.davem@davemloft.net> To: tangbin@cmss.chinamobile.com Cc: andrew@lunn.ch, hkallweit1@gmail.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshengju@cmss.chinamobile.com Subject: Re: [PATCH] net: mdio: Remove redundant parameter and check From: David Miller In-Reply-To: <20200923100532.18452-1-tangbin@cmss.chinamobile.com> References: <20200923100532.18452-1-tangbin@cmss.chinamobile.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 23 Sep 2020 17:53:45 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin Date: Wed, 23 Sep 2020 18:05:32 +0800 > @@ -125,12 +124,9 @@ ipq8064_mdio_probe(struct platform_device *pdev) > return PTR_ERR(priv->base); > } > > - ret = of_mdiobus_register(bus, np); > - if (ret) > - return ret; > - > platform_set_drvdata(pdev, bus); > - return 0; > + > + return of_mdiobus_register(bus, np); > } You are changing the code rather than simplifying the return sequence. The author of this code intended the platform_set_drvdata() to only happen if all operations of this function succeeded. I am not applying this patch, sorry.