Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Po Liu <po.liu@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: RE: [net-next] net: dsa: felix: convert TAS link speed based on
 phylink speed
Thread-Topic: [net-next] net: dsa: felix: convert TAS link speed based on
 phylink speed
Thread-Index: AQHWkM5TaOCnSiK1nk+I7CbW7JsXual0h6+AgAKFUFA=
Date:   Thu, 24 Sep 2020 02:10:02 +0000
Message-ID: <DB8PR04MB578529D733A50F048A1EB793F0390@DB8PR04MB5785.eurprd04.prod.outlook.com>
References: <20200922104302.17662-1-xiaoliang.yang_1@nxp.com>
 <20200922113644.h5vyxmdtg2dickpg@skbuf>
In-Reply-To: <20200922113644.h5vyxmdtg2dickpg@skbuf>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bd686a65-8c9e-4648-c97b-08d8602ef2c5
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2020 02:10:02.9176
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ioxk8/6R4W/vMS6P8rd5Xwg+gtv6Zfu0I7kq/vDaVYHdYuWGAkFAHhV8O6Sp0TFMBTGXXEGC44LKA4Fv9ADkdpiJ+Tf6I5jvrwoH4IwZTqc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5307
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Tue, Sep 22, 2020 at 19:37, Vladimir Oltean wrote:
>=20
> Hi Xiaoliang,
>=20
> On Tue, Sep 22, 2020 at 06:43:02PM +0800, Xiaoliang Yang wrote:
> > state->speed holds a value of 10, 100, 1000 or 2500, but
> > QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert
> > the speed to a proper value.
> >
> > Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler
> > via taprio offload")
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> > ---
>=20
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>=20
> But next time keep in mind the following:
>=20
> - The Fixes: tag should never wrap on multiple lines, even if it exceeds
>   80 characters.
> - Patches that fix a problem in net-next only should go to David's
>   net-next tree. Patches that fix a problem on Linus Torvalds' tree
>   should go to David's "net" tree. This one should go to "net", not to
>   "net-next".
> - All tags (Fixes, Signed-off-by, etc) should be grouped together with
>   no empty lines between them.
>=20
> Actually due to the first issue I mentioned, could you please resend this=
?
>=20
> Thanks,
> -Vladimir

I modify the commit and resend this patch to "net tree", please reject this=
 one.

Thanks,
Xiaoliang Yang