Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp857480pxk; Wed, 23 Sep 2020 19:17:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKoda+RBXbw61Qt9CBkTsQr4vEV37TUNOcIbnr2N4ILEcN5KmJOCrup3VGggEjp4P81Xh1 X-Received: by 2002:a17:906:4f16:: with SMTP id t22mr2453098eju.40.1600913877396; Wed, 23 Sep 2020 19:17:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600913877; cv=none; d=google.com; s=arc-20160816; b=q+n9umD6kzFuxUNMyZo6bM0l+qDxtIebdrdcIdGEJVYZm+fPOJekaxudnlioh8xCk9 3E/ra+I/imGsWZ6sHHpfSIW4bLgmVhz1qzwC4VPEZhtiSN01/tYGklt36BurHE9Bo503 dIoXuaMev0AHMtp7jN0xgjxMn4JjO5+40WREWkbNcmLccSk8la4bflwt/doEC/KLhf5c dGrRcEhnQMpTyTTPOJqGn6E7TbSVmB65xz6/Z9qoACBI9jERSRFYpwLC0l6PnOeQZoUe ONZUxYtk/QaAqhLX/06lTA9YCwjHWRZ+u3oXsqA1eMChB5Qx2RT7jTziw583taWL+J4G KgZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=qVhlsQsN+ZzC09nqESiGIFd/mC1Q6oyhIrBiOaZFemw=; b=Kp7oaXZbePdpO/0APrCn9hbyNLmngKy7ZWi7hZbuy6v+NcNqG/hrj0qBLF21ynzdMT yZ0R5Pjk9KK98QSu0GsAw7j+yflmXh0AEsE/GInN85nPbNlYSfp4fnUSrZPaJTkwkUkV y995g3lOuPj3ZwjnS+CAW9E6YoBDl09OHN+OtvlYXeazS7RgBSiBrDuOqgwQKgi7z9d5 o8zHOV76q0/ils5n8k2zsNrYmdaiYJV4htgr+aS7MYu0N2R5Uwgbju2aFsDo7DnBi12f aPHV9TozhSMIPPilDXAfUc6L5TVXnRmdXihADy8yOCTjnjCd2xbk5Eljr60iM0b7Zn3U loVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=c7gbGDEi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p18si1193924edr.166.2020.09.23.19.17.33; Wed, 23 Sep 2020 19:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=c7gbGDEi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726344AbgIXCQd (ORCPT + 99 others); Wed, 23 Sep 2020 22:16:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:44670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbgIXCQd (ORCPT ); Wed, 23 Sep 2020 22:16:33 -0400 Received: from [192.168.0.112] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 654E82176B; Thu, 24 Sep 2020 02:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600913793; bh=UELaYOKqHb8RFS7awWB7SBPi8SatHXgZinBl51mIqhA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=c7gbGDEitoOV/W2DnX+cdMuYoDI3uvq+RmSEcRpiArC9Z84+8E16k/r6R6fn4SexA 25g3+OOCLuv7SLSOwQVtzrMBBg5mfKqKU15eJGzXZfxWo/BPhH7Kx4SIpA01kPmQv8 s8ty/HdBsknebpN0Pltys29xDGX9yNWHZT3bkH5g= Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call To: "Kuppuswamy, Sathyanarayanan" , Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, Jay Vosburgh References: <20200922233333.GA2239404@bjorn-Precision-5520> <704c39bf-6f0c-bba3-70b8-91de6a445e43@linux.intel.com> <3d27d0a4-2115-fa72-8990-a84910e4215f@kernel.org> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: <526dc846-b12b-3523-4995-966eb972ceb7@kernel.org> Date: Wed, 23 Sep 2020 22:16:31 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/23/2020 10:04 PM, Kuppuswamy, Sathyanarayanan wrote: >> AFAIK, DLLSC is a requirement not optional. Why is this not supported by >> non-hotplug ports? > Its required for hotplug capable ports. Please check PCIe spec v5.0 sec > 6.7.3.3. > > The Data Link Layer State Changed event provides an indication that the > state of > the Data Link Layer Link Active bit in the Link Status Register has > changed. > Support for Data Link Layer State Changed events and software > notification of these > events are required for hot-plug capable Downstream Ports. I see. Can I assume that your system supports DPC? DPC is supposed to recover the link via dpc_reset_link().