Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Sep 2020 11:17:56 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        John Ogness <john.ogness@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Prarit Bhargava <prarit@redhat.com>,
        Mark Salyzyn <salyzyn@android.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Changki Kim <changki.kim@samsung.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/2] printk: Add more information about the printk caller
Message-ID: <20200924021756.GD577@jagdpanzerIV.localdomain>
References: <20200923135617.27149-1-pmladek@suse.com>
 <20200923135617.27149-3-pmladek@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200923135617.27149-3-pmladek@suse.com>
Precedence: bulk

On (20/09/23 15:56), Petr Mladek wrote:
[..]
>  	/*
>  	 * To reduce unnecessarily reopening, first check if the descriptor
> -	 * state and caller ID are correct.
> +	 * state and caller infromation are correct.
>  	 */
> -	d_state = desc_read(desc_ring, id, &desc, NULL, &cid);
> -	if (d_state != desc_committed || cid != caller_id)
> +	d_state = desc_read(desc_ring, id, &desc, NULL, &cal);
> +	if (d_state != desc_committed ||
> +	    cal.pid != caller->pid ||
> +	    cal.cpu_ctx != caller->cpu_ctx) {

You probably might want to factor out ctx check into a static
inline helper. Since you use this check in several places, and
we may check more context fields in the future.

[..]
> +/* Information about the process and context that adds the message */
> +struct printk_caller {
> +	pid_t pid;	/* thread id */
> +	u32 cpu_ctx;	/* processor id and interrupt context */
> +};

A question. Suppose we have a task which does

	CPU0

	pr_err(...);

	preempt_disable();
	pr_err(...);
	preempt_enable();

	pr_err(...);

	rcu_read_lock();
	pr_info(...);
	rcu_read_unlock();

Should we distinguish those as 3 different contexts?

- normal printk
- printk under disabled preemption (affects scheduling)
- printk under RCU read side lock (affects RCU grace periods)

	-ss