Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932511AbWHDAeN (ORCPT ); Thu, 3 Aug 2006 20:34:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932555AbWHDAeN (ORCPT ); Thu, 3 Aug 2006 20:34:13 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:59323 "EHLO e32.co.us.ibm.com") by vger.kernel.org with ESMTP id S932511AbWHDAeM (ORCPT ); Thu, 3 Aug 2006 20:34:12 -0400 Subject: Re: [PATCH] memory hotadd fixes [4/5] avoid check in acpi From: keith mannthey Reply-To: kmannth@us.ibm.com To: KAMEZAWA Hiroyuki Cc: lkml , lhms-devel , "y-goto@jp.fujitsu.com" , Andrew Morton In-Reply-To: <20060803123604.0f909208.kamezawa.hiroyu@jp.fujitsu.com> References: <20060803123604.0f909208.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain Organization: Linux Technology Center IBM Date: Thu, 03 Aug 2006 17:13:16 -0700 Message-Id: <1154650396.5925.49.camel@keithlap> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 33 On Thu, 2006-08-03 at 12:36 +0900, KAMEZAWA Hiroyuki wrote: > add_memory() does all necessary check to avoid collision. > then, acpi layer doesn't have to check region by itself. > > (*) pfn_valid() just returns page struct is valid or not. It returns 0 > if a section has been already added even is ioresource is not added. > ioresource collision check in mm/memory_hotplug.c can do more precise > collistion check. > added enabled bit check just for sanity check.. > > Signed-Off-By: KAMEZAWA Hiroyuki > - start_pfn = info->start_addr >> PAGE_SHIFT; > - end_pfn = (info->start_addr + info->length - 1) >> PAGE_SHIFT; > - > - if (pfn_valid(start_pfn) || pfn_valid(end_pfn)) { This check needs to go somewhare in the add path. I am thinking of a validate_add_memory_area call in add_memory (that can also be flexable to enable the reserve check of (this memory area in add_nodes). It is a useful protection for the sparsemem add path. I would rather the kernel be able to stand up to odd acpi namespaces or other mechanisms of invoking add_memory. Thanks, Keith - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/