Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp7283pxk; Wed, 23 Sep 2020 20:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ5EqksbXu9hWRpy/x7jdgibjQCccbV2nGmEKnsjakKKzvyLr7N3/6n3gIeDNZl2D0E+L0 X-Received: by 2002:a17:906:1b58:: with SMTP id p24mr2686412ejg.77.1600917512905; Wed, 23 Sep 2020 20:18:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600917512; cv=none; d=google.com; s=arc-20160816; b=y4XPIK3/UV/36gn0YQuJw2xKn1O6bKAlmLLH+Zt9V9Brxla9DrWTwD2o2KHjSODa4E hRbkQyG2R1AEG9reItEOz/swq8bgDq5YD1yanWOfjzGqKXUCubzFeSI92cxnM9NaGXRb fjg7x6EPfTgD6DTxIljUQJ4OegsfRpa8CBhVYpBWkkgqZI7E8vGg9tZ5ONlZrmv/lffX 1ZvwHu9zF0xLvhk9ZT7+oRFeo4a+1Rpgz7ZgsNfsKkK0t0pjH05H8SFWiY08zN5fxlp/ U4pCuU5h0FQOrNtOY4b3BlhNhEgvqVIqgGRABJetUC1+4LTv1FyhGK36rbzvlYUuJXpa a1ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=xdMeleM0FhXHxLcJCZNIfSQPP+PzVPbzvjgttifE0tU=; b=N1LUpS/b3YSQowS/GYnqsvUzNpD1QuSG/kKbyuZNh7QUlNrHBTYL7dAv8gsahTCSyQ pv48YVanSxjov89FULxVmYjzgiySMtm5QwjMjts+6TzF67QcCwFIjb66R/N/h8/3G3o7 3lR9okQx70+qHXte/bUOjvP+Ot8TWrpWNdLcgMCeEP8d0liV4KcNGyQsCsGYB3EFJLrr QZRsVi7e2c8abiUt986S/4V472I6p64IwWp++zfLjHwh+D8cn2zbzeNrEsXNW+sma+Lz OMZ4tOnirXcMublGQRiFoWH7g1e9VDSDQ91ZUJgu2ChUl9Lox1j/9t9ktBYGzxlClLws Sb1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vVSuMSUB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m23si1243550ejo.333.2020.09.23.20.18.08; Wed, 23 Sep 2020 20:18:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vVSuMSUB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbgIXDNz (ORCPT + 99 others); Wed, 23 Sep 2020 23:13:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:59280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbgIXDNz (ORCPT ); Wed, 23 Sep 2020 23:13:55 -0400 Received: from [192.168.0.112] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2786206CD; Thu, 24 Sep 2020 03:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600917234; bh=xdMeleM0FhXHxLcJCZNIfSQPP+PzVPbzvjgttifE0tU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=vVSuMSUBPeb7GH/ormLkd7AykL/eyHAgTyUw7mkdYVoKZMgn5hwJjEYKNemW3vbNE dpUjaK7Nk/lfEGnEaieWL1k39QflVERFUYB7GWq8wXwGwb8DfebHyKJ6mQvzEFT6WR tN1SV9AcplWatfu1PbmPXcX0umlR15LUhowhCnjY= Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call To: "Kuppuswamy, Sathyanarayanan" , Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, Jay Vosburgh References: <20200922233333.GA2239404@bjorn-Precision-5520> <704c39bf-6f0c-bba3-70b8-91de6a445e43@linux.intel.com> <3d27d0a4-2115-fa72-8990-a84910e4215f@kernel.org> <526dc846-b12b-3523-4995-966eb972ceb7@kernel.org> <1fdcc4a6-53b7-2b5f-8496-f0f09405f561@linux.intel.com> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: Date: Wed, 23 Sep 2020 23:13:52 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1fdcc4a6-53b7-2b5f-8496-f0f09405f561@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/23/2020 10:51 PM, Kuppuswamy, Sathyanarayanan wrote: >> >> I see. Can I assume that your system supports DPC? >> DPC is supposed to recover the link via dpc_reset_link(). > Yes. But the affected device/drivers cleanup during error recovery > is handled by hotplug handler. So we are facing issue when dealing > with non hotplug capable ports. This is confusing. Why would hotplug driver be involved unless port supports hotplug and the link goes down? You said that DLLSC is only supported on hotplug capable ports. Need a better description of symptoms and what triggers hotplug driver to activate. Can you expand this a little bit?