Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp94326pxk; Wed, 23 Sep 2020 23:55:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZcB5pE7KJ4NZrX1tnnUXZiT49x/HMulAJlnADZw0s5kg+Mxg6OxPlml0cQt7/7Cbim89T X-Received: by 2002:a50:9dc8:: with SMTP id l8mr3158777edk.58.1600930544411; Wed, 23 Sep 2020 23:55:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600930544; cv=none; d=google.com; s=arc-20160816; b=vmRlGA+rR4TWFdo0iEnN5m9dxkT50JeyyTysuPcyHuw7W3nqvdSMaylPivMNJ8aZ22 Bbv05LcJn2fnPpyf6x/+fjM4VIXIG4zYyFivqXJfdW/yp0/fHLL2sYp+PZKpnyLyMzn5 5f9E3wKI5B0NTx8SZJC0FpOSlrtYX+HE55Rf74Jc6KkbbswCkaMDce8tCzVYKUdxjUqA n1qQ8qKO+Hfrcf4pzhJ3fyHtJrjIuWmexlu0395I2u4krY8cL8FbxrH0mEeOe+CWaZe4 NuJslpBuPC1vWxQTz+bo2APW2F9uJ6uHh21IO5UFs2BhBllFye72KBeD+bMqwhO9PdxM VoUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g9xVnmRLNXPehcB4PdT7j+hjYku/j4udzyGtMh1GMwg=; b=v78a0inzYQG1tyQWgowgBJb8pWb7DT7HnGRXIH2wgP4v3/fbUXVpahnI5B/bssXN6K thuXJn/82q9w6LLe5qMheNS5viiyZ5K9U3NDJDx2Wlic6yNx5D6TFllwtOmx/R3OMSGo uubaiwiQKY8ZfjvHV88WAtMmMzf9icGxv71SzMdUCnyvJN19cc+VhL27JWBWdrrGa69d Jg7zyGvo85VhjPP3TUsoFhnGwCKgNg1weVb4E/hEv3p6LQznMQ5cZiSwyvVJ7AjQMpy/ raO1vbOuvXx1w5mhW2eYu1oKOy7yyaKLwFxBaFKuYNlbZ4hPz3UN7YuIYuhJSHCjeQpi maZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=L6rYs9Sg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nx23si1567511ejb.291.2020.09.23.23.55.20; Wed, 23 Sep 2020 23:55:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=L6rYs9Sg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbgIXGxN (ORCPT + 99 others); Thu, 24 Sep 2020 02:53:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbgIXGwB (ORCPT ); Thu, 24 Sep 2020 02:52:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47AE6C0613D3; Wed, 23 Sep 2020 23:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=g9xVnmRLNXPehcB4PdT7j+hjYku/j4udzyGtMh1GMwg=; b=L6rYs9SgfbS93bAxFavESPGoy0 /v4w1xHKzUlgbK7M4J4CfEklqmTuP2Z/b95hBWtxRTKXZM2PVUt7f4/gSSAFoLGN2git2oF5dLDwh TSLtJUhfBUrAXO9zkv+5p3NWTXtFLm3D8EMaWzzFlgrsHn61ZVCByA0wmc8fkLa3okgAXVOozzmiS 4rdy3q4Io0SIE7nJ6FE9igOCKmRGmE5Lv5ZKxomzwPp1dYsWWeKuiPxEpUh/iDHCQAft+lM3+BSxP MCvW3VsvvRaDMI9viLfFCmAnA8bzSX6j3m2/KNgIrWab8PfiT3CagUBPdUVzdoZvWuLIrBAc0ghF8 EWnVjA0w==; Received: from p4fdb0c34.dip0.t-ipconnect.de ([79.219.12.52] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLL6X-00019u-Ek; Thu, 24 Sep 2020 06:51:47 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Song Liu , Hans de Goede , Coly Li , Richard Weinberger , Minchan Kim , Johannes Thumshirn , Justin Sanders , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Jan Kara Subject: [PATCH 04/13] aoe: set an optimal I/O size Date: Thu, 24 Sep 2020 08:51:31 +0200 Message-Id: <20200924065140.726436-5-hch@lst.de> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200924065140.726436-1-hch@lst.de> References: <20200924065140.726436-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org aoe forces a larger readahead size, but any reason to do larger I/O is not limited to readahead. Also set the optimal I/O size, and remove the local constants in favor of just using SZ_2G. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara --- drivers/block/aoe/aoeblk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index 5ca7216e9e01f3..d8cfc233e64b93 100644 --- a/drivers/block/aoe/aoeblk.c +++ b/drivers/block/aoe/aoeblk.c @@ -347,7 +347,6 @@ aoeblk_gdalloc(void *vp) mempool_t *mp; struct request_queue *q; struct blk_mq_tag_set *set; - enum { KB = 1024, MB = KB * KB, READ_AHEAD = 2 * MB, }; ulong flags; int late = 0; int err; @@ -407,7 +406,8 @@ aoeblk_gdalloc(void *vp) WARN_ON(d->gd); WARN_ON(d->flags & DEVFL_UP); blk_queue_max_hw_sectors(q, BLK_DEF_MAX_SECTORS); - q->backing_dev_info->ra_pages = READ_AHEAD / PAGE_SIZE; + q->backing_dev_info->ra_pages = SZ_2M / PAGE_SIZE; + blk_queue_io_opt(q, SZ_2M); d->bufpool = mp; d->blkq = gd->queue = q; q->queuedata = d; -- 2.28.0