Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp115749pxk; Thu, 24 Sep 2020 00:40:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQ9CNW4cqdtVin9eT4v1EbrvXIV6yHUkkTgYDPRuhPWCkpRmk5IQkx2bvX1kfRtwFaaBS9 X-Received: by 2002:aa7:d4d4:: with SMTP id t20mr3197480edr.229.1600933221831; Thu, 24 Sep 2020 00:40:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600933221; cv=none; d=google.com; s=arc-20160816; b=e+LFZ8RkxmLP/fM6+z/7Sc2nuPA0VM4ytOzhf0OSxZ+0BpSlZ1lf226FUA4YX9qo2d ucS2Iih9IjZTWR/vkzyO1puQmLmLFRlOYedv255rcoqsyawSJxe6mIRj3UJfUmYeJ+Rq z9YI5utO106ryY6jwq6WpIYgosfZK0+kknlV02UH8R1hSd1J3a0BIUYj9pME3tRGIEm9 /VppsF45DvGruHFYavny3Oho27p8/AbalO8RgJ1z+7vExXEm239W7xgfjBAlPvQ3qQ1f kg8LwmKQo0wZcL0f1VaO42H5jlj6Fd6avwWS0fQMccl45hLcfQSZ3lNNZFamMSlQO/iB kUMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=+eY8+fXvngYj7XnYGCkUG8jrRpVijqI96ZMj1LGmxWE=; b=1FFtxh8s5kf/UudDO5EhsA9lHbp54Y0/0pjSdsZ+Cm/Wx/ZVLdi2DffIXIM95UppOe eL3OYdKXaHvBUD4fc+xULZTijK7lxsFkDjvdTk1iVVWzy890ekL8EKsoCWwgIfGWc0P+ 1eCmXHpaCEQUZAMeVfa55bLHAZSK9Za/Q40B2gMdYs42bv9Oi3QSNaS7qF6Kuzq2afVY 6IWtuQMC+s5kdccL+40+j5Xj5Z5L+R+L6Vca8nX0Dz8IEBGFIc2HES3u2n+zDtm/Ir7B u83uVsU44M/lLbCILcMFmCBPYcU2hJHvqe/A+KooeEhwIKGV71gdJGE7qTFwigBEapRl VKmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=WnvFZcXf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z19si1533509edx.205.2020.09.24.00.39.58; Thu, 24 Sep 2020 00:40:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=WnvFZcXf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbgIXHif (ORCPT + 99 others); Thu, 24 Sep 2020 03:38:35 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:17935 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727109AbgIXHie (ORCPT ); Thu, 24 Sep 2020 03:38:34 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 24 Sep 2020 00:36:58 -0700 Received: from mtl-vdi-166.wap.labs.mlnx (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 24 Sep 2020 07:38:14 +0000 Date: Thu, 24 Sep 2020 10:38:10 +0300 From: Eli Cohen To: Jason Wang CC: , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls Message-ID: <20200924073810.GB170403@mtl-vdi-166.wap.labs.mlnx> References: <20200924032125.18619-1-jasowang@redhat.com> <20200924032125.18619-2-jasowang@redhat.com> <20200924071609.GA170403@mtl-vdi-166.wap.labs.mlnx> <042dc3f9-40f0-f740-7ffc-611d315bc150@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <042dc3f9-40f0-f740-7ffc-611d315bc150@redhat.com> User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13) X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600933019; bh=+eY8+fXvngYj7XnYGCkUG8jrRpVijqI96ZMj1LGmxWE=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To:User-Agent:X-Originating-IP:X-ClientProxiedBy; b=WnvFZcXfAFVVIByiIYbR+uKmdmmTlMOmyJvEJc7hCQzIVGcGXGJpD+Dr8/YQNWcGg LOq+tR9i0Kn2gD+iaqawryJBcoNJcj0c+vW76jzqg3upQD2YeqCQTbXCK4MIWhA3PI lDpNIHqe+WIjBtzCHb/k1rKcunqeiKFw/mXkCAjFuMITzH1bgwKpaDH79HQmpfXH7q Pn93V4GsDH+6iYuiV3nRBeysiY2jNruBumG9wFHncs53dFH1sCAH3WhFhyjlvn6U8D RayV6/I9+AKyi4lgpDVV1YdjlCyRr+DTl2/pLDiZ4Y3TIj+SiMJrf2EHOamqFvw+0w biH0TccDh6mQA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 03:26:08PM +0800, Jason Wang wrote: >=20 > On 2020/9/24 =E4=B8=8B=E5=8D=883:16, Eli Cohen wrote: > > On Thu, Sep 24, 2020 at 11:21:02AM +0800, Jason Wang wrote: > > > Commit 653055b9acd4 ("vhost-vdpa: support get/set backend features") > > > introduces two malfunction backend features ioctls: > > >=20 > > > 1) the ioctls was blindly added to vring ioctl instead of vdpa device > > > ioctl > > > 2) vhost_set_backend_features() was called when dev mutex has already > > > been held which will lead a deadlock > > >=20 > > I assume this patch requires some patch in qemu as well. Do you have > > such patch? > >=20 >=20 > It's this series: [PATCH 0/3] Vhost-vDPA: batch IOTLB updating. >=20 > You were copied. >=20 Right, I miss those. Thanks.