Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp148535pxk; Thu, 24 Sep 2020 01:50:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxym/DJa9WtAu9riZWHuHtr1JgRAMA9Q6YjG10dtpTPC9blnuM8ykojtmsQHoi2S3pvhjlo X-Received: by 2002:a17:906:4cd6:: with SMTP id q22mr3441670ejt.139.1600937417872; Thu, 24 Sep 2020 01:50:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600937417; cv=none; d=google.com; s=arc-20160816; b=q+PmbsV8d/A0fCfe330XUl+7MQnLg+GGsCTQ1qpbTfkgo5mZBiYmc/Lfgj0WGADdKf UsDHpTLX5tUQZ6UdkEFNh7GU2tRP6HuoYDjRorBwzJNIhOmEkwSxoHDt3IiKsVzAdPf5 eWuisVzi/i+Q+4vquQrtPwYM2iwH3fJWkUQDorf4OUGbwSjiLmFOlk+k9tyx/dDIUoaX SRtm+OV+Ww+yzinYDxl9Ss64/xNsSnPbVsF4S2CtPPHFVuUd1VaAEEUMo/BaemddPzND VKZzFSoV47hvX32ymcgEPA3UTpAe/tF0gelddfITa8zQgqdmfH6DErosznj28RSqahr2 j9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=nemlXBElVbbLfGgtH0z7XOG+YzFruW68yvK6oAbJBlw=; b=G3b5/gX8nR3BfyU++g+FnLKlwxs3ZF3QuSBHBeo9kI1Gg57bYbcomfErya+77anvrB TWZEq3xjFX/6PtGqgi/gh2KyZRqG3AQAG3YDqv+gIKUpvcbre6clCnepAtBsuS99piUq MQecMPJU9XN44zhBBKJfsw4KTngWV6ehrPVtt91ajwLcKU2IuCkf+VWCYBriswVbyPfG Fdx07agV8SCvlHmhrui4/s4T2373+Q/6tspdMM+hlVCOLMuPNm9fjYYWbF4IBfBMONZc Ebl9d11K6fwiHJQWmA5epV++wineqj/Jnbbs3LccGsWoRwz1mobF+tHYNrGEeF27KQLk R5jw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw20si1780633edb.141.2020.09.24.01.49.54; Thu, 24 Sep 2020 01:50:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbgIXIsw (ORCPT + 99 others); Thu, 24 Sep 2020 04:48:52 -0400 Received: from 8bytes.org ([81.169.241.247]:46202 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbgIXIsw (ORCPT ); Thu, 24 Sep 2020 04:48:52 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 5200C295; Thu, 24 Sep 2020 10:48:50 +0200 (CEST) Date: Thu, 24 Sep 2020 10:48:48 +0200 From: Joerg Roedel To: Marek Szyprowski Cc: Yu Kuai , kgene@kernel.org, krzk@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate() Message-ID: <20200924084848.GD27174@8bytes.org> References: <20200918011335.909141-1-yukuai3@huawei.com> <9f5b25ee-3dad-1798-fe55-9c1af9cde513@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f5b25ee-3dad-1798-fe55-9c1af9cde513@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2020 at 05:27:59PM +0200, Marek Szyprowski wrote: > Hi > > On 18.09.2020 03:13, Yu Kuai wrote: > > if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have > > a corresponding put_device(). Thus add put_device() to fix the exception > > handling for this function implementation. > > > > Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices from device tree") > > Signed-off-by: Yu Kuai > > Thanks for the fix! > > Acked-by: Marek Szyprowski Applied for v5.9, thanks.