Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp151781pxk; Thu, 24 Sep 2020 01:58:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytwIsalaLbXJDDlFKrqPxawu1BRM1BR+koUcJElXhAXq1F1o6StxSI/xJIo9wz6UFKBI5Z X-Received: by 2002:a17:906:454e:: with SMTP id s14mr3637294ejq.137.1600937892189; Thu, 24 Sep 2020 01:58:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600937892; cv=none; d=google.com; s=arc-20160816; b=sF5lN0v1lwM6uMTLe9II6uYuVsFZjl7EmZYZm4uGLMrpv5IXo4UX0Jd/2kCqx8QKUr BHDU/O46c+yqu73ybcKRLpJX//nxi7gDBpaASPeCSijYmzTlU7pUZgvjNJFPh/rxZhXX kY5qw1qxb22pDDbDemLqUQfR5OvD4r5EA6ceoaDuaAaMgoRZgg1E9bp0jdn0Hc0We/wg y9PipU2dKSijd7RB9RxIWD8Y/AFEsTn2lWYjxd6ozECUBTEC+Q5P6ovYtpGhqDUV4TdM vTnny0yrT+a8OqvQrnYfFdKSY9r4f8vslp53b8X7KEMfNVKe0A1k0ds94A7NMkf2n/ef 1AOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:reply-to; bh=LUTnPMXd2BrYRWSphNF3a96rGTr2zIYT+N6O4Enki1Q=; b=ghJtv1Y++IrcCOgFCAje5gfjqXi35CnvotIAlBCXjixD/uYNPlUypRtMYTkhaRv0WU mkvCh3XZVM/aj2iHK7Lt0/J2d7dgkY6H6XzysKTsWPqgEbbuVxxQ9YxHOGWcCY/w/XO7 KY9+jvZA5fCe3TPHeDGQWBPTT4um4noVvyarrDEbKCrQ2LQBjfoo6E+jQENCNYl6QcWy 5ip6ogwCxUvgqcudqYgLCCqL0rj3SCb54wEKVxkISZAVieEf1YNQM/eaXt5s+8GqFh1K PCcTKSbBS/SsUMBlvXn8bgaT/fN6bRrW4rlA0HvTDt5qpq2Qn3mNsCkdsQAI/HFzZ77h Gjmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si1459833ejs.146.2020.09.24.01.57.48; Thu, 24 Sep 2020 01:58:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727295AbgIXIyr (ORCPT + 99 others); Thu, 24 Sep 2020 04:54:47 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:35356 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727274AbgIXIyq (ORCPT ); Thu, 24 Sep 2020 04:54:46 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R661e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=xlpang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0U9xKTdd_1600937682; Received: from xunleideMacBook-Pro.local(mailfrom:xlpang@linux.alibaba.com fp:SMTPD_---0U9xKTdd_1600937682) by smtp.aliyun-inc.com(127.0.0.1); Thu, 24 Sep 2020 16:54:43 +0800 Reply-To: xlpang@linux.alibaba.com Subject: Re: [PATCH RESEND] sched/fair: Fix wrong cpu selecting from isolated domain To: Vincent Guittot , Xunlei Pang Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Jiang Biao , Wetp Zhang , linux-kernel References: <1600930127-76857-1-git-send-email-xlpang@linux.alibaba.com> From: Xunlei Pang Message-ID: Date: Thu, 24 Sep 2020 16:54:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/24/20 3:18 PM, Vincent Guittot wrote: > On Thu, 24 Sep 2020 at 08:48, Xunlei Pang wrote: >> >> We've met problems that occasionally tasks with full cpumask >> (e.g. by putting it into a cpuset or setting to full affinity) >> were migrated to our isolated cpus in production environment. >> >> After some analysis, we found that it is due to the current >> select_idle_smt() not considering the sched_domain mask. >> >> Steps to reproduce on my 31-CPU hyperthreads machine: >> 1. with boot parameter: "isolcpus=domain,2-31" >> (thread lists: 0,16 and 1,17) >> 2. cgcreate -g cpu:test; cgexec -g cpu:test "test_threads" >> 3. some threads will be migrated to the isolated cpu16~17. >> >> Fix it by checking the valid domain mask in select_idle_smt(). >> >> Fixes: 10e2f1acd010 ("sched/core: Rewrite and improve select_idle_siblings()) >> Reported-by: Wetp Zhang >> Reviewed-by: Jiang Biao >> Signed-off-by: Xunlei Pang > > Reviewed-by: Vincent Guittot > Thanks, Vincent :-)