Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 2/3] dt-bindings: usb: cdns,usb3: Add
 cdns,phyrst-a-enable property
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>, <balbi@kernel.org>
CC:     <pawell@cadence.com>, <kurahul@cadence.com>, <nsekhar@ti.com>,
        <vigneshr@ti.com>, <robh+dt@kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <20200915114543.2599-1-rogerq@ti.com>
 <20200915114543.2599-3-rogerq@ti.com>
 <1b45d695-0874-69c7-8398-5d14033f0788@gmail.com>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <20b1126a-d328-ab79-2624-7ddece6b56b0@ti.com>
Date:   Thu, 24 Sep 2020 12:51:35 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1b45d695-0874-69c7-8398-5d14033f0788@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Sergei,

On 15/09/2020 19:15, Sergei Shtylyov wrote:
> Hello!
> 
> On 9/15/20 2:45 PM, Roger Quadros wrote:
> 
>> Controller version 0x0002450D has USB2 PHY RX sensitivity issues
>> that needs to be worked around by enabling phyrst-a-enable bit
>> in PHYRST_CFG register.
>>
>> There is no way to know controller version before device controller
>> is started and the workaround needs to be applied for both host and
>> device modes, so we add this DT property.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>   Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> index 9b14c8443d39..ac20b98e9910 100644
>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> @@ -61,6 +61,10 @@ properties:
>>         buffers expressed in KB
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>   
>> +  cdns,phyrst-a-enable:
>> +    description: Enable resetting of PHY if Rx fail is detected
> 
>     Failure?

Actually the IP manual says "Reset PHY if Rx fail is detected".

So let's leave it like that.
> 
> [...]
> 
> MBR, Sergei
> 

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki